feat(api): allow for configuration of trusted proxies #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarrow
reviewed
Aug 24, 2023
| @@ -152,6 +152,11 @@ app: | |||
| tracingEnabled: false | |||
| errorReportingEnabled: false | |||
|
|
|||
| trustedProxy: | |||
| # if planning to use this, pass a list of proxy IPs or CIDRs: | |||
There was a problem hiding this comment.
I assume it works but I was surprised not to see cidr when grepping the docs. Is that just undocumented functionality?
There was a problem hiding this comment.
If I understand it correctly, this is basically https://github.com/fideloper/TrustedProxy vendored into Laravel itself, which also does not mention CIDRs, but uses them in its documentation https://github.com/fideloper/TrustedProxy/wiki/IP-Addresses-of-Popular-Services
deer-wmde
approved these changes
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion PR for wbstack/api#637