feat(http): allow trusted proxies to be defined #637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After deploying #635 to staging I noticed links in pagination responses would be using the
httpprotocol, when the application itself is served usinghttps. This seems to be due to the fact that as configured, Laravel does not trust any proxies at all and will think the client is the ingress, which rewrites tohttp: https://github.com/wbstack/charts/blob/af3206a791b345a70dd8b1670e20ff3d4e30d57a/charts/api/templates/ingress.yaml#L26-L37This PR introduces the possibility of configuring trusted proxies as documented here: https://laravel.com/docs/8.x/requests#configuring-trusted-proxies