Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wazuh_template_branch to 4.8.1 #5499

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

Rebits
Copy link
Member

@Rebits Rebits commented Jun 14, 2024

Description

This PR update wazuh_template_branch to 4.8.1

Testing performed

Build: https://ci.wazuh.info/job/Test_e2e_system/301/

@Rebits Rebits linked an issue Jun 14, 2024 that may be closed by this pull request
@Rebits Rebits self-assigned this Jun 14, 2024
@Rebits Rebits marked this pull request as ready for review June 17, 2024 08:48
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checking the repository we could see that there are more files with the hardcoded version, for example, provisioning/roles/wazuh/ansible-wazuh-agent/defaults/main.yml:

In addition, this is not maintainable, we must check if this version is essential (in the same playbook in the installation by sources is v4.4.4) and if it is, look for a way to parameterize it, if not, we will have to take into account these files every time we make a version bump.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These values are default and not currently used in provisioning.

The inclusion of some playbooks from a wazuh-ansible repository for provisioning the E2E VD environment was a condition accepted. This has resulted in non-maintainable code. However, refactoring is not planned as we intend to migrate to new tools in the future.

I suggest replacing all hardcoded values in each version bump

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proposed changes will be carried on #5509

@juliamagan juliamagan merged commit 0a9dc21 into 4.8.1 Jun 19, 2024
2 of 3 checks passed
@juliamagan juliamagan deleted the fix/5498-change-provision-template branch June 19, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update wazuh_template_branch in filebeat provision template
3 participants