Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hardcoded references to branch in provision playbooks for E2E tests #5509

Closed
3 tasks done
Rebits opened this issue Jun 19, 2024 · 3 comments · Fixed by #5517
Closed
3 tasks done

Remove hardcoded references to branch in provision playbooks for E2E tests #5509

Rebits opened this issue Jun 19, 2024 · 3 comments · Fixed by #5517
Assignees
Labels

Comments

@Rebits
Copy link
Member

Rebits commented Jun 19, 2024

Description

The E2E vulnerability detection tests currently use playbooks from the QA repository to provision the environment. However, these playbooks are inherited from the Wazuh Ansible repository and include hardcoded versions, making the repository difficult to maintain. More information can be found in this discussion.

To address this issue, it has been proposed to remove these hardcoded references, adapt the Ansible playbook modules to our needs, and update the provisioning modules in the Jenkins libraries accordingly.

Tasks

  • Remove any hardcoded references in the provision modules in the QA repository
  • Include necessary parameters in Jenkins pipelines to replace hardcoded values

Validation

  • Ensure E2E vulnerability detection tests are provisioned and run correctly after removing hardcoded references.
@santipadilla
Copy link
Member

santipadilla commented Jun 24, 2024

@santipadilla
Copy link
Member

Update

Machines were destroyed in the pipeline copy due to name change with suffix _dev. More details here.
Launched and modified original pipeline with the new parameter: https://ci.wazuh.info/job/Test_e2e_system/

@wazuhci wazuhci moved this from In progress to Pending review in Release 4.8.1 Jun 26, 2024
@wazuhci wazuhci moved this from Pending review to On hold in Release 4.8.1 Jun 27, 2024
@wazuhci wazuhci moved this from On hold to In progress in Release 4.8.1 Jun 27, 2024
@wazuhci wazuhci moved this from In progress to Pending review in Release 4.8.1 Jun 28, 2024
@wazuhci wazuhci moved this from Pending review to In review in Release 4.8.1 Jun 28, 2024
@wazuhci wazuhci moved this from In review to Pending final review in Release 4.8.1 Jun 28, 2024
@wazuhci wazuhci moved this from Pending final review to In final review in Release 4.8.1 Jun 28, 2024
@Rebits
Copy link
Member Author

Rebits commented Jun 28, 2024

Moved ETA to 02/07/2024 to allow apply requested changes

@wazuhci wazuhci moved this from In final review to On hold in Release 4.8.1 Jun 28, 2024
@wazuhci wazuhci moved this from On hold to In progress in Release 4.8.1 Jun 28, 2024
@wazuhci wazuhci moved this from In progress to Pending review in Release 4.8.1 Jul 1, 2024
@wazuhci wazuhci moved this from Pending review to In review in Release 4.8.1 Jul 1, 2024
@wazuhci wazuhci moved this from In review to On hold in Release 4.8.1 Jul 1, 2024
@wazuhci wazuhci moved this from On hold to In progress in Release 4.8.1 Jul 1, 2024
@wazuhci wazuhci moved this from In progress to In review in Release 4.8.1 Jul 1, 2024
@wazuhci wazuhci moved this from In review to Pending final review in Release 4.8.1 Jul 1, 2024
@wazuhci wazuhci moved this from Pending final review to In final review in Release 4.8.1 Jul 1, 2024
@wazuhci wazuhci moved this from In final review to Done in Release 4.8.1 Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants