Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix help menu links #424

Merged
merged 2 commits into from
Nov 20, 2024
Merged

Fix help menu links #424

merged 2 commits into from
Nov 20, 2024

Conversation

yenienserrano
Copy link
Member

@yenienserrano yenienserrano commented Nov 20, 2024

Description

return the help menu icons and links to the way they were in version 4.9.2

Issues Resolved

Screenshot

image

Testing the changes

Open the help menu and make sure that the links labels and icons are correct and that the opensearch links are not there.

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@yenienserrano yenienserrano linked an issue Nov 20, 2024 that may be closed by this pull request
5 tasks
@yenienserrano yenienserrano changed the title Fix/265-help-menu-links Fix help menu links Nov 20, 2024
Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: 🟢
Test: 🟢

image

@guidomodarelli
Copy link

guidomodarelli commented Nov 20, 2024

Legend:
⚫: The test hasn't started yet
🟢: All checks passed.
🟡: There is at least one expected fail or skipped test and no failures.
🔴: There is at least one failed check.
⚪: Doesn't apply

TEST 🟢

image

@asteriscos asteriscos merged commit 566acd8 into 4.10.0 Nov 20, 2024
60 of 61 checks passed
@asteriscos asteriscos deleted the fix/265-help-menu-links branch November 20, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compatibility with OpenSearch 2.16.0
4 participants