Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with Opensearch Dashboard 2.16.0 #6921

Merged
merged 4 commits into from
Aug 21, 2024

Conversation

yenienserrano
Copy link
Member

@yenienserrano yenienserrano commented Aug 19, 2024

Description

Change the version of Opensearch Dashboards in the plugins and add the versions in our development environments.

Issues Resolved

wazuh/wazuh-dashboard#265

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@yenienserrano yenienserrano self-assigned this Aug 19, 2024
@yenienserrano yenienserrano linked an issue Aug 19, 2024 that may be closed by this pull request
5 tasks
@Desvelao
Copy link
Member

Desvelao commented Aug 20, 2024

The check did not pass: https://github.com/wazuh/wazuh-dashboard-plugins/actions/runs/10459680080/job/28964170966?pr=6921

The problem is related to the test needs source code in ESM that is not supported natively by jest. I found a configuration on the OpenSearch dashboards repository that could solve the problem https://github.com/opensearch-project/OpenSearch-Dashboards/blob/2.16.0/src/dev/jest/config.js#L186-L189.

Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 46.02% ( 400 / 869 )
Branches 41.97% ( 157 / 374 )
Functions 44.01% ( 136 / 309 )
Lines 46.22% ( 398 / 861 )

Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.44% ( 172 / 225 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.44% ( 172 / 225 )

Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 13.59% ( 4016 / 29532 )
Branches 9.09% ( 1755 / 19300 )
Functions 13.31% ( 947 / 7110 )
Lines 13.77% ( 3914 / 28416 )

Copy link
Member

@Desvelao Desvelao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chantal-kelm chantal-kelm self-requested a review August 21, 2024 13:25
@asteriscos asteriscos merged commit 8cd576f into 4.10.0 Aug 21, 2024
5 checks passed
@asteriscos asteriscos deleted the maintenance/265-compatibility-with-opensearch-2160 branch August 21, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compatibility with OpenSearch 2.16.0
4 participants