-
Notifications
You must be signed in to change notification settings - Fork 12
Fix/prevent double console log commenting #377
Fix/prevent double console log commenting #377
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@@ -17,6 +17,21 @@ const app = new App({ | |||
appId: process.env.GITHUB_APP_ID!, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file contains at least one console log. Please remove any present.
WatermelonAI SummaryThis PR prevents double console log commenting, reducing complexity. It includes code changes to move a constant prompt, extract a hash getter, await a result, fix a type, and extract text. Overall, it aims to fix a bug and improve the codebase. No results found in GitHub PRs :( Click here to login to Jira Notion PagesNo results found in Linear Tickets :( Click here to login to Asana |
WatermelonAI SummaryThis PR prevents the double posting of console logs by moving a constant prompt, extracting a hash getter, awaiting the result, fixing a type, extracting text, and removing unused imports. No results found in GitHub PRs :( Click here to login to Jira Notion PagesNo results found in Linear Tickets :( Click here to login to Asana |
WatermelonAI SummaryThis PR fixes the issue of double console log commenting by preventing double posting and reducing complexity. It includes several commits that move a constant prompt, extract a hash getter, await a result, fix a type, extract text, remove unused imports, and rewrite a diffing function. The PR also includes acceptance criteria and references the contributing guidelines and code of conduct. GitHub PRs
Click here to login to Jira Notion PagesNo results found in Linear Tickets :( Click here to login to Asana |
return result.data.head.sha; | ||
}) | ||
.catch((err) => { | ||
console.log(err); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file contains at least one console log. Please remove any present.
WatermelonAI SummaryThis PR fixes a bug related to double posting and reduces complexity. It includes various commits that involve moving, extracting, fixing, and rewriting functions. The goal is to prevent double console log commenting in order to improve the functionality of the system. GitHub PRs
Click here to login to Jira Notion PagesLinear TicketsClick here to login to Asana |
WatermelonAI SummaryThis PR fixes a bug related to double posting and reduces complexity. It includes multiple commits that improve different parts of the code, such as extracting functions, fixing types, removing unused imports, and rewriting a diffing function. Overall, it aims to enhance the codebase and prevent the issue of double console log commenting. GitHub PRs
Click here to login to Jira Notion PagesNo results found in Linear Tickets :( Click here to login to Asana |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested on #379 and it LGTM. I sent various Postman payloads and didn't get multiple comments.
return result.data.head.sha; | ||
}) | ||
.catch((err) => { | ||
console.log(err); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file contains at least one console log. Please remove any present.
WatermelonAI SummaryThis PR fixes an issue preventing double console log commenting. It includes various changes to the code, such as moving the constant prompt, extracting a hash getter, fixing a type, extracting text, removing unused imports, rewriting a diffing function, fixing a function, and using falsy values to return. These changes aim to reduce complexity and improve the code's functionality. GitHub PRs
Click here to login to Jira Notion PagesNo results found in Linear Tickets :( Click here to login to Asana |
return result.data.head.sha; | ||
}) | ||
.catch((err) => { | ||
console.log(err); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file contains at least one console log. Please remove any present.
WatermelonAI SummaryThis PR fixes a bug that caused double console log commenting. It moves a constant prompt, extracts a hash getter, awaits a result, fixes a type, extracts text, removes unused imports, rewrites a diffing function, fixes a function, and uses falsy values to return. GitHub PRs
Click here to login to Jira Notion PagesNo results found in Linear Tickets :( Click here to login to Asana |
Description
Prevents double posting and reduces complexity
Type of change
Notes
Acceptance