Skip to content
This repository has been archived by the owner on Mar 12, 2024. It is now read-only.

Feature/uninstall email #366

Merged
merged 7 commits into from
Nov 15, 2023
Merged

Feature/uninstall email #366

merged 7 commits into from
Nov 15, 2023

Conversation

EstebanDalelR
Copy link
Member

Description

Sends a feedback email to users that uninstall the app

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Chore: cleanup/renaming, etc
  • RFC

Notes

Acceptance

Copy link

vercel bot commented Nov 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
watermelon ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 15, 2023 5:04pm

}
)
.catch((err) => {
console.log(err);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file contains at least one console log. Please remove any present.

sgMail
.sendMultiple(msg)
.then(() => {
console.log("Email sent");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file contains at least one console log. Please remove any present.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There you go! just fix this

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh so should it be sent to Posthog or...?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like a plan, but don't be too strict about it.

WatermelonAI Summary

This PR adds the ability to send a feedback email to users who uninstall the app. It includes changes such as adding catch statements, creating a sendUninstall.ts file, removing unused parameters, and extracting the actionName. Overall, this PR introduces a new feature that enhances user experience by sending feedback emails upon uninstallation.

GitHub PRs

Click here to login to Jira
Click here to login to Confluence
No results found in Slack Threads :(

No results found in Notion Pages :(

No results found in Linear Tickets :(

Click here to login to Asana
watermelon is an open repo and Watermelon will serve it for free.
🍉🫶
Have you starred Watermelon?

Copy link
Collaborator

@baristaGeek baristaGeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would've done this via Zapier, but it LGTM anyway. Just remove prod console logs and that's it

This was referenced Nov 10, 2023
@EstebanDalelR
Copy link
Member Author

I would've done this via Zapier, but it LGTM anyway. Just remove prod console logs and that's it

How does Zapier detect the team that uninstalled @baristaGeek ?

@baristaGeek
Copy link
Collaborator

I would've done this via Zapier, but it LGTM anyway. Just remove prod console logs and that's it

How does Zapier detect the team that uninstalled @baristaGeek ?

I checked on Zapier and we can't trigger that event. I stand corrected.

sgMail
.sendMultiple(msg)
.then(() => {
console.log("Email sent");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file contains at least one console log. Please remove any present.

WatermelonAI Summary

This PR titled "Feature/uninstall email" adds functionality to send a feedback email to users who uninstall the app. The commits in this PR include adding exception handling, creating a new file for sending the uninstall email, removing unused parameters, and extracting the action name. These changes enhance the user experience by providing a way to collect feedback from uninstalling users.

GitHub PRs

Click here to login to Jira
Click here to login to Confluence
No results found in Slack Threads :(

No results found in Notion Pages :(

No results found in Linear Tickets :(

Click here to login to Asana
watermelon is an open repo and Watermelon will serve it for free.
🍉🫶
Why not invite more people to your team?

@EstebanDalelR EstebanDalelR merged commit 4817f85 into dev Nov 15, 2023
2 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants