fix: Remove rewrites to enable Firebase use of 404.html as default #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- **Changes**: - Removed the `rewrites` block from `transformer-firebase.js`. - **Impact**: - Ensures Firebase correctly uses `404.html` as the default error page. - Corrects the returned HTTP status code to 404 instead of 200 for missing routes. - **Reason**: - Aligns with Firebase best practices for handling 404 errors with proper status codes.
|
Visit the preview URL for this PR (updated for commit 03de176): https://bvarga-fe600--pr86-fix-custom-404-page-qp7ceftp.web.app (expires Mon, 16 Dec 2024 11:45:36 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: a3b1098a9eaf0750a134a339972f1df2a3969a8d |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
rewritesblock fromtransformer-firebase.js.Impact:
404.htmlas the default error page.Reason: