Skip to content

Commit

Permalink
fix: Remove rewrites to enable Firebase use of 404.html as default (#86)
Browse files Browse the repository at this point in the history
- **Changes**:
  - Removed the `rewrites` block from `transformer-firebase.js`.

- **Impact**:
  - Ensures Firebase correctly uses `404.html` as the default error page.
  - Corrects the returned HTTP status code to 404 instead of 200 for missing routes.

- **Reason**:
  - Aligns with Firebase best practices for handling 404 errors with proper status codes.
  • Loading branch information
warnyul authored Dec 9, 2024
1 parent 68e8ba9 commit 0502539
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions transformer-firebase.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,6 @@ module.exports = (headers) => {
'**/.*',
'**/node_modules/**',
],
rewrites: [
{
"source": "**",
"destination": "/404.html"
},
],
headers: [
{
source: '**/*.@(ico|jpg|jpeg|gif|png|webp|js.map|js|css|txt|html)',
Expand Down

0 comments on commit 0502539

Please sign in to comment.