-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(filter): peer/subscription renewal with recurring Filter pings #2052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danisharora099
force-pushed
the
feat/filter-renew-peers
branch
from
July 3, 2024 07:40
bffda11
to
da6cd5f
Compare
danisharora099
changed the title
feat(filter): peer renewal with recurring Filter pings
feat(filter): peer/subscription renewal with recurring Filter pings
Jul 3, 2024
size-limit report 📦
|
danisharora099
commented
Jul 3, 2024
weboko
reviewed
Jul 3, 2024
weboko
reviewed
Jul 3, 2024
weboko
reviewed
Jul 3, 2024
weboko
reviewed
Jul 3, 2024
weboko
reviewed
Jul 3, 2024
weboko
reviewed
Jul 3, 2024
weboko
reviewed
Jul 3, 2024
5 tasks
weboko
reviewed
Jul 4, 2024
weboko
reviewed
Jul 10, 2024
weboko
reviewed
Jul 10, 2024
weboko
reviewed
Jul 10, 2024
weboko
approved these changes
Jul 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
everything else seems fine
danisharora099
force-pushed
the
feat/filter-renew-peers
branch
from
July 10, 2024 08:52
1267f5d
to
3516b43
Compare
Merged
39 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When using the Filter protocol, we create subscriptions with multiple peers. This increases the inherent reliability considering we have multiple nodes that can provide us with an incoming Filter messages. To continue this effort, it is helpful to be able to observe the nodes that are not as reliable specifically, and act on renewing them with potentially healthy peers.
Solution
As part of increasing reliability for Filter, doing recurring Filter pings on nodes with whom we have open subscriptions and expect incoming Filter messages from:
Notes
Contribution checklist:
!
in title if breaks public API;