Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: numPeers in BaseProtocol.getPeers() should not take 0 for all peers #2055

Open
danisharora099 opened this issue Jul 8, 2024 · 0 comments
Open

chore: numPeers in BaseProtocol.getPeers() should not take 0 for all peers #2055

danisharora099 opened this issue Jul 8, 2024 · 0 comments
Labels
debt Technical debt marker enhancement New feature or request

Comments

@danisharora099
Copy link
Collaborator

This is a change request

Problem

js-waku/packages/core/src/lib/base_protocol.ts

Line 79 in 4db508b

* @param numPeers - The total number of peers to retrieve. If 0, all peers are returned.
numPeers takes in 0 as the value if all peers are to be returned. This is unintuitive to correlate 0 with all peers

Proposed Solutions

Using Infinity instead of 0 would be more intuitive

Notes
@fryorcraken fryorcraken added this to Waku Jul 8, 2024
@danisharora099 danisharora099 mentioned this issue Jul 8, 2024
Merged
3 tasks
@weboko weboko moved this to Triage in Waku Jul 10, 2024
@weboko weboko moved this from Triage to To Do in Waku Jul 10, 2024
@weboko weboko added enhancement New feature or request debt Technical debt marker labels Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
debt Technical debt marker enhancement New feature or request
Projects
Waku
Status: To Do
Milestone
No milestone
Development

No branches or pull requests
2 participants
@danisharora099 @weboko