Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify put to have password in body instead of query param #149

Merged
merged 3 commits into from
May 13, 2024

Conversation

VictoriqueMoe
Copy link
Member

This PR moves the password field from query param to body param

@VictoriqueMoe VictoriqueMoe marked this pull request as draft May 3, 2024 20:44
nakedmcse
nakedmcse previously approved these changes May 3, 2024
Copy link
Member

@nakedmcse nakedmcse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change makes sense. Puts password where it should be. Approved.

@VictoriqueMoe VictoriqueMoe marked this pull request as ready for review May 12, 2024 19:15
nakedmcse
nakedmcse previously approved these changes May 12, 2024
Copy link
Member

@nakedmcse nakedmcse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

# Conflicts:
#	package-lock.json
#	package.json
@VictoriqueMoe VictoriqueMoe dismissed nakedmcse’s stale review May 12, 2024 19:17

The merge-base changed after approval.

Copy link
Member

@nakedmcse nakedmcse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@VictoriqueMoe VictoriqueMoe merged commit 404c9e2 into main May 13, 2024
1 check passed
@VictoriqueMoe VictoriqueMoe deleted the modify-put-request branch May 13, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants