Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move password from query to body #8

Closed
VictoriqueMoe opened this issue May 12, 2024 · 0 comments · Fixed by #9
Closed

Move password from query to body #8

VictoriqueMoe opened this issue May 12, 2024 · 0 comments · Fixed by #9
Assignees
@ernestmarcinko
Labels
enhancement New feature or request

Comments

@VictoriqueMoe
Copy link
Member

the password param has been moved from the query param to the body waifuvault/WaifuVault#149

the change you make here should not break the SDK, the arguments passed will be the same, just internally move the password from qurey to body. see: waifuvault/waifuVault-node-api#14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ernestmarcinko ernestmarcinko

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: moved the password field from URI param to body param waifuvault/waifuVault-php-api
2 participants
@ernestmarcinko @VictoriqueMoe