Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for address, contact info from PR API (align with pull request 955) #389

Merged
merged 5 commits into from
May 10, 2021

Conversation

ianbjacobs
Copy link
Contributor

@ianbjacobs ianbjacobs commented May 5, 2021

  1. Andre Lyver moved to former editor
  2. Removed shipping, contact information to align with PR 955 on PR API
    Drop PaymentAddress, shipping + billing address support payment-request#955

The following tasks have been completed:

  • tidy
  • no respect errors
  • web platform tests (link)
  • MDN Docs added (link)

Implementation commitment:

  • Safari (link to issue)
  • Chrome
  • Firefox (link to issue)
  • Edge (public signal)

Preview | Diff

2) Removed shipping, contact information to align with PR 955 on PR API
   w3c/payment-request#955
updated tidyconfig to align with PR API version
@ianbjacobs
Copy link
Contributor Author

A note on this pull request: There are some change indications that are not areas that I edited. I'm not sure if this is due to some text not having been tidied before, or new tidy behavior. Sorry for that noise.

@ianbjacobs
Copy link
Contributor Author

More notes:

  • If we remove modifiers from PR API, we will want to make corresponding edits here, but that should happen in a separate pull request.
  • Also for future consideration depending on changes to PR API: localization of some of the strings (e.g., errors)

mzkei
mzkei approved these changes May 6, 2021
Copy link
Member

@romandev romandev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ianbjacobs
Copy link
Contributor Author

@rsolomakhin, does anything need to happen on the Chrome side by virtue of updating the spec this way (e.g., bug tracker as was done for the PR API edit)?

@rsolomakhin
Copy link
Collaborator

Filed https://crbug.com/1207601.

Copy link
Collaborator

@rsolomakhin rsolomakhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

index.html Outdated Show resolved Hide resolved
@ianbjacobs ianbjacobs merged commit 6d44221 into gh-pages May 10, 2021
rsolomakhin added a commit to rsolomakhin/payment-handler that referenced this pull request Jan 11, 2023
This reverts commit 6d44221: "Remove
support for address, contact info from PR API (align with pull request
955) (w3c#389)."
rsolomakhin added a commit to rsolomakhin/payment-handler that referenced this pull request Jan 11, 2023
This reverts commit 6d44221: "Remove
support for address, contact info from PR API (align with pull request
955) (w3c#389)."
rsolomakhin added a commit to rsolomakhin/payment-handler that referenced this pull request Jan 11, 2023
This reverts commit 6d44221: "Remove
support for address, contact info from PR API (align with pull request
955) (w3c#389)."
rsolomakhin added a commit that referenced this pull request Jan 11, 2023
* Bring back shipping and contact information.

This reverts commit 6d44221: "Remove
support for address, contact info from PR API (align with pull request
955) (#389)."

* Add note about state of address support.

* Remove billingAddress to align with existing implementations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants