-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bring back shipping and contact information. #406
Conversation
As addresses and contact-info are coming back to PaymentRequest API, we would like to keep address/contact-info support in Payment Handler API, too. @stephenmcgruer & @ianbjacobs PTAL. |
Hi @rsolomakhin, Are there any changes to the text other than restoring what was once there? Also, I'd like to request the addition of an informative note acknowledging that we will be looking at privacy implications of restoring these features. See my suggested text in PR API: Thank you! |
Hi @ianbjacobs! Should this pull request be discussed in a W3C meeting before merging?
I also cleaned up a couple of ReSpec warnings. That should be negligible. This is 99.9% restoring what was once there.
I've placed your suggested text in the "Security and Privacy Considerations" section. |
Let's not bring back |
Thanks for this, @rsolomakhin. Would you be available for a brief summary at the end of the 19 January call? |
Yes, I will attend and summarize. Should this be merged after the 19 January call, or can it be merged now, in your opinion? |
I'm fine personally if you want to merge now and then discuss. I would like to be sure in the discussion that we understand the motivation for the restoration and discuss a process for addressing the privacy concerns previously raised. Thanks again and talk to you on the 19th. |
@stephenmcgruer - Are you also OK with the plan in the #406 (comment)? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not review the PR in-depth, trusting that it is as described in the above conversation, but the plan SGTM. Thanks Rouslan!
This reverts commit 6d44221: "Remove support for address, contact info from PR API (align with pull request 955) (#389)."
Preview | Diff