Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify the fields API #668

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Specify the fields API #668

Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c8b28c8
Specify the fields API
cbiesinger Oct 28, 2024
5751d6c
Address comments from TallTed
cbiesinger Oct 29, 2024
01b3796
npm comments
cbiesinger Nov 7, 2024
c23d5d5
Merge remote-tracking branch 'origin' into fields
cbiesinger Nov 19, 2024
dec043b
TallTed oxford commas
cbiesinger Nov 19, 2024
c357604
Merge remote-tracking branch 'origin' into fields
cbiesinger Dec 4, 2024
b1c4998
allow UAs to not show the permission prompt
cbiesinger Dec 4, 2024
b5760fe
comments
cbiesinger Dec 5, 2024
cf5dc42
note
cbiesinger Dec 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions spec/index.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1377,9 +1377,15 @@ an {{IdentityProviderAPIConfig}} |config|, an {{IdentityProviderRequestOptions}}
1. If |fields| is not [=list/empty=], set |metadata| to the result of running [=fetch the client
metadata=] with |config|, |provider|, and |globalObject|.
1. Prompt the user to gather explicit intent to create an account. The user agent MAY use the
{{IdentityProviderBranding}} to inform the style choices of its UI. Additionally:
1. The user agent SHOULD <dfn>support showing a permission prompt</dfn> as follows.
1. If |fields| is not [=list/empty=] and the user agent [=supports showing a permission prompt=]:
{{IdentityProviderBranding}} to inform the style choices of its UI. Additionally, if the user agent
<dfn>supports showing a permission prompt</dfn>:

Note: Identity providers should support showing their own permission prompt using
{{IdentityAssertionResponse/continue_on}} when the `disclosure_shown_for` parameter
does not contain the fields required by the IDP. This is to support user agents that
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: support galore, use synonym sometimes?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
does not contain the fields required by the IDP. This is to support user agents that
does not contain the fields required by the IDP. This is to enable user agents that

do not support showing a permission prompt.

1. If |fields| is not [=list/empty=]:
1. If |metadata| is not failure, |metadata|["{{IdentityProviderClientMetadata/privacy_policy_url}}"]
cbiesinger marked this conversation as resolved.
Show resolved Hide resolved
is defined, and the |provider|'s {{IdentityProviderConfig/clientId}} is not in the list of
|account|["{{IdentityProviderAccount/approved_clients}}"], then the user agent MUST display
Expand Down
Loading