Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[link-validator] Missing file context-api.md #637

Merged
merged 3 commits into from
Aug 19, 2024
Merged

[link-validator] Missing file context-api.md #637

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6c29c70
[link-validator] Missing file context-api.md
simoneonofri Aug 19, 2024
8936cba
Update index.bs
simoneonofri Aug 19, 2024
51bdf0d
Update index.bs
simoneonofri Aug 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions spec/index.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2413,8 +2413,8 @@ The [=remote end steps=] are:
</figure>

Note: This command lets automation verify that the
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The correct solution is to point to https://w3c-fedid.github.io/FedCM/#dom-identitycredentialrequestoptions-context, not remove the note.

Copy link
Contributor Author

@simoneonofri simoneonofri Aug 19, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok thank you @npm1 👍 i edited the code to have the correct link and updated also the page on TR

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like PR preview is no longer working on the repo. I think this link works but there is no preview to double check

[context api](https://github.com/fedidcg/FedCM/blob/main/proposals/context-api.md)
was applied properly
[context api](#dom-identitycredentialrequestoptions-context)
was applied properly
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why the extra space here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@npm1 none specifically, removed


The [=remote end steps=] are:

Expand Down
Loading