[link-validator] Missing file context-api.md #637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello, There is a note, with a broken reference link. | Note: This command lets automation verify that the | [context api](https://github.com/fedidcg/FedCM/blob/main/proposals/context-api.md) | was applied properly I searched inside the repo and could not find it. I am proposing to remove it or feel free to modify the PR. Thanks, Simone P.S. this should be the last check for publication in `/TR`
npm1
reviewed
Aug 19, 2024
| @@ -2412,10 +2412,6 @@ The [=remote end steps=] are: | |||
| </table> | |||
| </figure> | |||
|
|
|||
| Note: This command lets automation verify that the | |||
There was a problem hiding this comment.
The correct solution is to point to https://w3c-fedid.github.io/FedCM/#dom-identitycredentialrequestoptions-context, not remove the note.
There was a problem hiding this comment.
ok thank you @npm1 👍 i edited the code to have the correct link and updated also the page on TR
There was a problem hiding this comment.
It looks like PR preview is no longer working on the repo. I think this link works but there is no preview to double check
correct link
npm1
approved these changes
Aug 19, 2024
| was applied properly | ||
| Note: This command lets automation verify that the | ||
| [context api](#dom-identitycredentialrequestoptions-context) | ||
| was applied properly |
There was a problem hiding this comment.
@npm1 none specifically, removed
github-actions bot
added a commit
that referenced
this pull request
Aug 19, 2024
SHA: dc0cfce Reason: push, by npm1 Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
to mattdanielbrown/WebID
that referenced
this pull request
Aug 21, 2024
SHA: dc0cfce Reason: push, by pull[bot] Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
npm1
pushed a commit
that referenced
this pull request
Sep 18, 2024
* [link-validator] Missing file context-api.md Hello, There is a note, with a broken reference link. | Note: This command lets automation verify that the | [context api](https://github.com/fedidcg/FedCM/blob/main/proposals/context-api.md) | was applied properly I searched inside the repo and could not find it. I am proposing to remove it or feel free to modify the PR. Thanks, Simone P.S. this should be the last check for publication in `/TR` * Update index.bs correct link * Update index.bs QA
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
There is a note with a broken reference link.
Note: This command lets automation verify that the [context api](https://github.com/fedidcg/FedCM/blob/main/proposals/context-api.md) was applied properlyI searched inside the repo and could not find it.
I am proposing to remove it, if it not exist anymore. Otherwise feel free to modify the PR.
Thanks,
Simone
P.S. This should be the last check for publication in
/TR