op-mode: T6537: remove unused cmd imported from vyos.utils.process (backport #3791) #3798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
Commit dc60fe9 ("op-mode: T6537: include hostname in the reboot/shutdown warning message") added a more local import of vyos.utils.process.cmd() that made the fglobal import obsolete and trigger a linter warning. $ make unused-imports -------------------------------------------------------------------- Your code has been rated at 10.00/10 (previous run: 10.00/10, +0.00) (cherry picked from commit 6b2e45c)
mergify
bot
requested review from
dmbaturin,
sarthurdev,
zdc,
jestabro,
c-po and
nicolas-fort
12 tasks
c-po
approved these changes
Jul 6, 2024
|
👍 |
|
❌ |
dmbaturin
approved these changes
Jul 6, 2024
sever-sever
approved these changes
Jul 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Commit dc60fe9 ("op-mode: T6537: include hostname in the reboot/shutdown warning message") added a more local import of
vyos.utils.process.cmd()that made the fglobal import obsolete and trigger a linter warning.Types of changes
Related Task(s)
Related PR(s)
Component(s) name
powerctl
Checklist:
This is an automatic backport of pull request #3791 done by [Mergify](https://mergify.com).