-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
op-mode: T6537: remove unused cmd imported from vyos.utils.process #3791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit dc60fe9 ("op-mode: T6537: include hostname in the reboot/shutdown warning message") added a more local import of vyos.utils.process.cmd() that made the fglobal import obsolete and trigger a linter warning. $ make unused-imports -------------------------------------------------------------------- Your code has been rated at 10.00/10 (previous run: 10.00/10, +0.00)
c-po
requested review from
dmbaturin,
sarthurdev,
zdc,
jestabro,
sever-sever and
fett0
July 5, 2024 07:04
👍 |
@Mergifyio backport circinus |
✅ Backports have been created
|
CI integration ❌ failed! Details
|
dmbaturin
approved these changes
Jul 5, 2024
sever-sever
approved these changes
Jul 5, 2024
12 tasks
@Mergifyio backport sagitta |
✅ Backports have been created
|
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Commit dc60fe9 ("op-mode: T6537: include hostname in the reboot/shutdown warning message") added a more local import of
vyos.utils.process.cmd()
that made the fglobal import obsolete and trigger a linter warning.Types of changes
Related Task(s)
Related PR(s)
Component(s) name
powerctl
Checklist: