Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op-mode: T6537: remove unused cmd imported from vyos.utils.process #3791

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

c-po
Copy link
Member

@c-po c-po commented Jul 5, 2024

Change Summary

Commit dc60fe9 ("op-mode: T6537: include hostname in the reboot/shutdown warning message") added a more local import of vyos.utils.process.cmd() that made the fglobal import obsolete and trigger a linter warning.

$ make unused-imports

--------------------------------------------------------------------
Your code has been rated at 10.00/10 (previous run: 10.00/10, +0.00)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Component(s) name

powerctl

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

Commit dc60fe9 ("op-mode: T6537: include hostname in the reboot/shutdown
warning message") added a more local import of vyos.utils.process.cmd() that
made the fglobal import obsolete and trigger a linter warning.

$ make unused-imports

--------------------------------------------------------------------
Your code has been rated at 10.00/10 (previous run: 10.00/10, +0.00)
@c-po c-po requested a review from a team as a code owner July 5, 2024 07:04
Copy link

github-actions bot commented Jul 5, 2024

👍
No issues in PR Title / Commit Title

@c-po
Copy link
Member Author

c-po commented Jul 5, 2024

@Mergifyio backport circinus

Copy link
Contributor

mergify bot commented Jul 5, 2024

backport circinus

✅ Backports have been created

@c-po c-po enabled auto-merge July 5, 2024 07:04
Copy link

github-actions bot commented Jul 5, 2024

CI integration ❌ failed!

Details

CI logs

  • ❌ failed CLI Smoketests returned: 1
  • 👍 passed Config tests returned: 0
  • 👍 passed RAID1 tests returned: 0

@c-po c-po merged commit 21a8578 into vyos:current Jul 5, 2024
12 of 14 checks passed
@c-po c-po deleted the T6537-powerctrl branch July 6, 2024 05:07
@c-po
Copy link
Member Author

c-po commented Jul 6, 2024

@Mergifyio backport sagitta

Copy link
Contributor

mergify bot commented Jul 6, 2024

backport sagitta

✅ Backports have been created

c-po added a commit that referenced this pull request Jul 6, 2024
op-mode: T6537: remove unused cmd imported from vyos.utils.process (backport #3791)
c-po added a commit that referenced this pull request Jul 7, 2024
op-mode: T6537: remove unused cmd imported from vyos.utils.process (backport #3791)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants