Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: events miss when there is a pod bind failed #2866

Merged
merged 1 commit into from
Dec 14, 2023
Merged

fix: events miss when there is a pod bind failed #2866

merged 1 commit into from
Dec 14, 2023

Conversation

lowang-bh
Copy link
Member

@lowang-bh lowang-bh commented May 27, 2023 •
edited
Loading

Describe: fix #2865 that successfully binding events will lost if a pod is failed to bind; fix #2879 metrics not accurate

key points:
1: replcace all clientset with interface
2: move event and metrics recoding to where pod is successfully bounden
3: add testcase about bind tasks

@volcano-sh-bot volcano-sh-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 27, 2023
@lowang-bh lowang-bh mentioned this pull request May 27, 2023
Merged
This was referenced May 30, 2023
Closed
Closed
@wangyang0616
Copy link
Member

It's ok to me，please help to review. Thanks! @william-wang @jiangkaihua

@lowang-bh lowang-bh mentioned this pull request May 30, 2023
Merged
@lowang-bh
Copy link
Member Author

trigger ci

@lowang-bh lowang-bh closed this May 31, 2023
@lowang-bh lowang-bh reopened this May 31, 2023
@lowang-bh lowang-bh mentioned this pull request May 31, 2023
Closed
@lowang-bh
Copy link
Member Author

@Thor-wl @hwdef Could you help review this pr? thanks.

hwdef
hwdef reviewed Jun 2, 2023
View reviewed changes
Copy link
Member

@hwdef hwdef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
I think this is OK, there is an unimportant suggestion that multiple commits can be split into multiple PRs.
Thanks for your contribution

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 2, 2023
@volcano-sh-bot volcano-sh-bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 2, 2023
@hwdef
Copy link
Member

hwdef commented Jun 6, 2023

@lowang-bh Is this PR ready to be review?

@lowang-bh
Copy link
Member Author

@lowang-bh Is this PR ready to be review?

Yes, plz help to review, thanks. @hwdef @wangyang0616 @Thor-wl

hwdef
hwdef reviewed Jun 7, 2023
View reviewed changes
Copy link
Member

@hwdef hwdef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Not much different from my last review.
Thanks for your contribution.

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 7, 2023
This was referenced Jul 8, 2023
Closed
Merged
@lowang-bh
Copy link
Member Author

/assign @Thor-wl

@volcano-sh-bot volcano-sh-bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 14, 2023
@lowang-bh
Copy link
Member Author

Hi, @william-wang , I updated this PR that newCache will create a new binder if there is no registered one.

image

@lowang-bh lowang-bh mentioned this pull request Aug 18, 2023
Merged
@lowang-bh
Copy link
Member Author

Hi, @wangyang0616, I think I have let it compariable with the old versions. The Bind Interface doesn't change.
cc @william-wang

@lowang-bh lowang-bh closed this Aug 18, 2023
@lowang-bh lowang-bh reopened this Aug 18, 2023
@william-wang
Copy link
Member

@lowang-bh I merged your PR #3064, you need to refresh this PR.

@lowang-bh
Copy link
Member Author

lowang-bh commented Sep 8, 2023 •
edited
Loading

@lowang-bh I merged your PR #3064, you need to refresh this PR.

Hi, @william-wang , this PR is already based from #3064. There will be no conflicts,I think.

@lowang-bh
fix: events miss when there is a pod bind failed
b48c7e6 
move event recoding to where pod is successfully bounden

Signed-off-by: lowang-bh <[email protected]>
@volcano-sh-bot volcano-sh-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 8, 2023
@lowang-bh
Copy link
Member Author

@lowang-bh I merged your PR #3064, you need to refresh this PR.

Hi, @william-wang , this PR is already based from #3064. There will be no conflicts,I think.

Have rebased from master.

@lowang-bh
Copy link
Member Author

Hi, @william-wang , any update on this PR?

@lowang-bh lowang-bh mentioned this pull request Dec 3, 2023
Open
william-wang
william-wang approved these changes Dec 14, 2023
View reviewed changes
Copy link
Member

@william-wang william-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 14, 2023
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: william-wang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 14, 2023
@volcano-sh-bot volcano-sh-bot merged commit c3d501b into volcano-sh:master Dec 14, 2023
13 checks passed
@lowang-bh lowang-bh mentioned this pull request Dec 14, 2023
Closed
@lowang-bh lowang-bh deleted the bindEnhancement branch May 1, 2024 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Monokaix Monokaix Monokaix left review comments

@hwdef hwdef hwdef left review comments

@william-wang william-wang william-wang approved these changes

@shinytang6 shinytang6 Awaiting requested review from shinytang6

@zen-xu zen-xu Awaiting requested review from zen-xu

Assignees

@william-wang william-wang

@hwdef hwdef

@Thor-wl Thor-wl

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

task scheduling latency metrics is not accurate if one pod binds failed, other pod's binding events lost
7 participants
@lowang-bh @wangyang0616 @hwdef @william-wang @volcano-sh-bot @Monokaix @Thor-wl