backfill add score process #2955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lowang-bh
force-pushed
the
backfill-improve
branch
2 times, most recently
from
1eb8850
to
a3bb1ba
Compare
volcano-sh-bot
added
the
size/M
lowang-bh
force-pushed
the
backfill-improve
branch
from
a3bb1ba
to
3d35d8a
Compare
|
@hwdef @wangyang0616 @Thor-wl Would please help to review it? |
|
/assign @william-wang @wangyang0616 @hwdef |
hwdef
reviewed
Jul 22, 2023
hwdef
reviewed
Jul 22, 2023
hwdef
reviewed
Jul 22, 2023
lowang-bh
force-pushed
the
backfill-improve
branch
from
3d35d8a
to
7024dba
Compare
|
/assign @Thor-wl |
|
Hi, @k82cn could you please help to review? Thanks. |
lowang-bh
force-pushed
the
backfill-improve
branch
from
7024dba
to
fdbb3e6
Compare
Signed-off-by: lowang-bh <[email protected]>
lowang-bh
force-pushed
the
backfill-improve
branch
from
fdbb3e6
to
6eb0130
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: william-wang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
volcano-sh-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2941 add priority score in backfill actions
Note:
I have try to add ut, but predicate and nodeorder plugin relay on k8s client which can not be overwrite with fakeclient.
Please merge PR #2866 with high priority and then can use interface to overwite k8sclient