-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Build under MacOS #4
base: main
Are you sure you want to change the base?
Conversation
Hi! Thank you for taking a look! Which tests fail due to the uniq issue? Can you post more information about the failure? |
❯ cargo build
Compiling dsrs v0.6.1 (/Users/ovr/projects/cube/datasketches-rs)
Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.27s
❯ cargo test
Finished `test` profile [unoptimized + debuginfo] target(s) in 0.09s
Running unittests src/lib.rs (target/debug/deps/dsrs-11c3d158f6d373f0)
running 23 tests
test wrapper::cpc::tests::union_empty ... ok
test wrapper::cpc::tests::cpc_empty ... ok
test wrapper::hh::tests::basic_merge ... ok
test wrapper::hh::tests::basic_heavy ... ok
test wrapper::hh::tests::check_hh_lgk4_multiplier2_nunique2 ... ok
test wrapper::hh::tests::check_hh_lgk4_multiplier20_nunique2 ... ok
test wrapper::hh::tests::check_hh_lgk4_multiplier20_nunique1 ... ok
test wrapper::hh::tests::check_hh_lgk4_multiplier2_nunique1 ... ok
test wrapper::hh::tests::check_hh_lgk4_multiplier2_nunique3 ... ok
test wrapper::hh::tests::hh_empty ... ok
test wrapper::hh::tests::retains_all_clone ... ok
test wrapper::hh::tests::retains_all ... ok
test wrapper::hh::tests::check_hh_lgk4_multiplier20_nunique3 ... ok
test wrapper::hh::tests::check_hh_lgk4_multiplier5_nunique1 ... ok
test wrapper::hh::tests::check_hh_lgk4_multiplier5_nunique3 ... ok
test wrapper::hh::tests::check_hh_lgk4_multiplier5_nunique2 ... ok
test stream_reducer::tests::reduces_stream ... ok
test wrapper::cpc::tests::basic_union_distinct ... ok
test wrapper::cpc::tests::basic_count_distinct ... ok
test wrapper::cpc::tests::basic_union_overlap ... ok
test wrapper::theta::tests::basic_count_distinct ... ok
test wrapper::theta::tests::basic_intersect_overlap ... ok
test wrapper::theta::tests::basic_intersect ... ok
test result: ok. 23 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 2.05s
Running unittests src/main.rs (target/debug/deps/dsrs-c04cf0ba333b261d)
running 10 tests
test tests::keyed_count_empty ... FAILED
test tests::hh_unique_lines ... ok
test tests::unique_lines ... FAILED
test tests::count_empty ... FAILED
test tests::equally_dup_lines ... FAILED
test tests::hh_count_empty ... FAILED
test tests::hh_equally_dup_lines ... FAILED
test tests::unequally_dup_lines ... FAILED
test tests::unique_keyed_lines ... FAILED
test tests::keyed_dup_lines ... FAILED
failures:
---- tests::keyed_count_empty stdout ----
thread 'tests::keyed_count_empty' panicked at src/main.rs:236:9:
uniq: invalid option -- w
usage: uniq [-c | -d | -D | -u] [-i] [-f fields] [-s chars] [input [output]]
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
---- tests::unique_lines stdout ----
thread 'tests::unique_lines' panicked at src/main.rs:385:9:
assertion `left == right` failed:
unix:
100
dsrs:
100
left: [32, 32, 32, 32, 32, 49, 48, 48, 10]
right: [49, 48, 48, 10]
---- tests::count_empty stdout ----
thread 'tests::count_empty' panicked at src/main.rs:385:9:
assertion `left == right` failed:
unix:
2
dsrs:
2
left: [32, 32, 32, 32, 32, 32, 32, 50, 10]
right: [50, 10]
---- tests::equally_dup_lines stdout ----
thread 'tests::equally_dup_lines' panicked at src/main.rs:385:9:
assertion `left == right` failed:
unix:
100
dsrs:
100
left: [32, 32, 32, 32, 32, 49, 48, 48, 10]
right: [49, 48, 48, 10]
---- tests::hh_count_empty stdout ----
thread 'tests::hh_count_empty' panicked at src/main.rs:385:9:
assertion `left == right` failed:
unix:
1 1
dsrs:
2
left: [49, 32, 49, 10]
right: [50, 32, 10]
---- tests::hh_equally_dup_lines stdout ----
thread 'tests::hh_equally_dup_lines' panicked at src/main.rs:385:9:
assertion `left == right` failed:
unix:
1 1000
1001 2
1001 3
dsrs:
1001 1
1001 2
1001 3
left: [49, 32, 49, 48, 48, 48, 10, 49, 48, 48, 49, 32, 50, 10, 49, 48, 48, 49, 32, 51, 10]
right: [49, 48, 48, 49, 32, 49, 10, 49, 48, 48, 49, 32, 50, 10, 49, 48, 48, 49, 32, 51, 10]
---- tests::unequally_dup_lines stdout ----
thread 'tests::unequally_dup_lines' panicked at src/main.rs:385:9:
assertion `left == right` failed:
unix:
100
dsrs:
100
left: [32, 32, 32, 32, 32, 49, 48, 48, 10]
right: [49, 48, 48, 10]
---- tests::unique_keyed_lines stdout ----
thread 'tests::unique_keyed_lines' panicked at src/main.rs:236:9:
uniq: invalid option -- w
usage: uniq [-c | -d | -D | -u] [-i] [-f fields] [-s chars] [input [output]]
---- tests::keyed_dup_lines stdout ----
thread 'tests::keyed_dup_lines' panicked at src/main.rs:236:9:
uniq: invalid option -- w
usage: uniq [-c | -d | -D | -u] [-i] [-f fields] [-s chars] [input [output]]
failures:
tests::count_empty
tests::equally_dup_lines
tests::hh_count_empty
tests::hh_equally_dup_lines
tests::keyed_count_empty
tests::keyed_dup_lines
tests::unequally_dup_lines
tests::unique_keyed_lines
tests::unique_lines |
It looks like Mac doesn't work since it doesn't have So instead of
let's instead use
or something similar (so that formatting matches). For |
Doesn't seem to work?
|
@timbray Could you try with https://rustup.rs/? llvm is a part of rust; as I can see from the error, you have a different llvm other than rust uses. |
Oops, sorry, my fault. Something went wrong and an llvm dependency was missing.
|
@vlad17, could you please approve the CI run? It's strange, but I don't see CI status. |
I've tested changes in my fork, it works https://github.com/cube-js/datasketches-rs/actions/runs/8976208069/job/24652549213 ✅ |
@vlad17, any plans to merge? Thanks |
Thanks for the bump, sorry about the delay. I was waiting for @timbray to comment if tests pass for his MacOs setup as of the new changes. Tim, do things work for you now with this branch? |
I'm having trouble figuring out how to get the right branch. (I'm a bit of a git moron). It looks like I should clone [email protected]:cube-js/datasketches-rs.git which builds but fails tests. What am I missing? |
Which tests fail? Any message? |
@timbray FYI: Don't forget to do |
D'oh, I'd forgotten you can clone a branch. I was fighting with "checkout" and so on. Anyhow, no luck: Unfortunately, looks about the same. See https://gist.github.com/timbray/3b4c3117a9ee82b797bee8ee8a39f36c |
|
Oh, that did it, pardon me missing that. All tests now passed. |
Excellent. Thank you both for following up. @ovr , mind updating the readme to mention |
Hello!
I've fixed an issue with compilation on MacOS and added CI.
Some tests fail with an issue that uniq on MacOS doesn't support
-w1
, I don't know how to port it.Fix ##3
Thanks