Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't build on MacOS #3

Open
timbray opened this issue Apr 12, 2024 · 4 comments
Open

Doesn't build on MacOS #3

timbray opened this issue Apr 12, 2024 · 4 comments

Comments

@timbray
Copy link

timbray commented Apr 12, 2024

cargo build
 ... much elided ...
  = note: ld: library 'stdc++' not found
          clang: error: linker command failed with exit code 1 (use -v to see invocation)

Apparently it's supposed to be libc++ not stdc++ these days but I'm not a Rustafarian and couldn't figure out how to make that work either.

@vlad17
Copy link
Owner

vlad17 commented Apr 21, 2024

Hey Tim, thanks for reporting this. Unfortunately, I don’t have a Mac and everything seems to be working fine on my old Ubuntu laptop.

googling around, adding this crate as a dependency locally might help? https://docs.rs/link-cplusplus/latest/link_cplusplus/

@timbray
Copy link
Author

timbray commented Apr 21, 2024 via email

@vlad17
Copy link
Owner

vlad17 commented May 6, 2024

@timbray , would you be able to try @ovr's fix?

@ovr
Copy link
Contributor

ovr commented May 6, 2024

@vlad17 FYI, as a part of changes in PR #4, I've added CI

https://github.com/cube-js/datasketches-rs/actions/runs/8970862322/job/24635298556

image

It builds successfully :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants