Migrate Workflow: Scope vindex names correctly when target and source keyspace have different names #16769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…names are different, we need to scope the vindex used in the vreplication filter to the local name Signed-off-by: Rohit Nayak <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
rohit-nayak-ps
added
Type: Bug
Component: VReplication
and removed
NeedsWebsiteDocsUpdate
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16769 +/- ##
==========================================
+ Coverage 68.98% 69.53% +0.54%
==========================================
Files 1562 1568 +6
Lines 200697 202442 +1745
==========================================
+ Hits 138459 140764 +2305
+ Misses 62238 61678 -560 ☔ View full report in Codecov by Sentry. |
rohit-nayak-ps
added
Backport to: release-18.0
Backport to: release-19.0
Signed-off-by: Rohit Nayak <[email protected]>
rohit-nayak-ps
requested review from
GuptaManan100,
frouioui,
deepthi,
mattlord,
harshit-gangal and
ajm188
as code owners
mattlord
reviewed
Sep 18, 2024
There was a problem hiding this comment.
In general it LGTM. I had some minor nits and suggestions, the only thing that I think we really should do is address the it is expected that the source and target keyspaces have the same vindex name and data type part and confirm that ourselves. Unless there's some reason(s) that we cannot?
| if mz.workflowType == binlogdatapb.VReplicationWorkflowType_Migrate { | ||
| // For a Migrate, if the TargetKeyspace name is different from the SourceKeyspace name, we need to use the | ||
| // SourceKeyspace name to determine the vindex since the TargetKeyspace name is not known to the source. | ||
| // Note: it is expected that the source and target keyspaces have the same vindex name and data type. |
There was a problem hiding this comment.
I think that we should check and confirm this expectation and error out if it's not true.
There was a problem hiding this comment.
It is assumed that the vschemas and tables etc are identical on source and target for Migrate. We can/should add all vaidations for this and all other workflow types in another PR. I don't want to add that to this PR.
| // cluster with keyspace rating. | ||
| func TestMigrateSharded(t *testing.T) { | ||
| setSidecarDBName("_vt") | ||
| defaultRdonly = 1 |
There was a problem hiding this comment.
Why set this? I don't see where we use it.
There was a problem hiding this comment.
This is that global variable that we have not refactored yet. It is used in creating future clusters in the test. Added code to keep previous values and reset in a defer.
Signed-off-by: Rohit Nayak <[email protected]>
mattlord
approved these changes
Sep 21, 2024
This was referenced Sep 21, 2024
vitess-bot
pushed a commit
that referenced
this pull request
Sep 21, 2024
… keyspace have different names (#16769) Signed-off-by: Rohit Nayak <[email protected]>
5 tasks
frouioui
pushed a commit
that referenced
this pull request
Oct 23, 2024
…rget and source keyspace have different names (#16769) (#16815) Signed-off-by: Rohit Nayak <[email protected]> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We use the target keyspace’s vindex for filtering out rows from the source intended for each target shard. The vindex is qualified by the target keyspace name. When the source cluster has a different name for the keyspace, it fails while trying to stream from the source cluster, because it cannot locate the vindex.
This PR sets the vindex scope to that of the source keyspace if the keyspace names differ. Note that it is assumed that the same vindexes are used on both keyspaces during a
MigrateRelated Issue(s)
#16777
Checklist
Deployment Notes