Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-19.0] Fix vtctldclient SwitchReads related bugs and move the TestBasicV2Workflows e2e test to vtctldclient (#15579) #15584

Merged
merged 1 commit into from
Mar 27, 2024

VReplication: Move the Reshard v2 workflow to vtctldclient (#15579)

584e8b7
Select commit
Loading
Failed to load commit list.
Merged

[release-19.0] Fix vtctldclient SwitchReads related bugs and move the TestBasicV2Workflows e2e test to vtctldclient (#15579) #15584

VReplication: Move the Reshard v2 workflow to vtctldclient (#15579)
584e8b7
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 27, 2024 in 0s

67.43% (+0.03%) compared to 3ce8f87

View this Pull Request on Codecov

67.43% (+0.03%) compared to 3ce8f87

Details

Codecov Report

Attention: Patch coverage is 0% with 32 lines in your changes are missing coverage. Please review.

Project coverage is 67.43%. Comparing base (3ce8f87) to head (584e8b7).

Files Patch % Lines
go/vt/vtctl/workflow/traffic_switcher.go 0.00% 17 Missing ⚠️
go/vt/vtctl/workflow/server.go 0.00% 13 Missing ⚠️
...lient/command/vreplication/common/switchtraffic.go 0.00% 1 Missing ⚠️
go/vt/vttablet/tabletmanager/rpc_vreplication.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-19.0   #15584      +/-   ##
================================================
+ Coverage         67.40%   67.43%   +0.03%     
================================================
  Files              1560     1560              
  Lines            192661   192655       -6     
================================================
+ Hits             129857   129923      +66     
+ Misses            62804    62732      -72     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.