Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-19.0] Fix vtctldclient SwitchReads related bugs and move the TestBasicV2Workflows e2e test to vtctldclient (#15579) #15584

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

vitess-bot[bot]
Copy link
Contributor

@vitess-bot vitess-bot bot commented Mar 27, 2024

Description

This is a backport of #15579

Fixes: #15594

Copy link
Contributor Author

vitess-bot bot commented Mar 27, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@github-actions github-actions bot added this to the v19.0.2 milestone Mar 27, 2024
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 32 lines in your changes are missing coverage. Please review.

Project coverage is 67.43%. Comparing base (3ce8f87) to head (584e8b7).

Files Patch % Lines
go/vt/vtctl/workflow/traffic_switcher.go 0.00% 17 Missing ⚠️
go/vt/vtctl/workflow/server.go 0.00% 13 Missing ⚠️
...lient/command/vreplication/common/switchtraffic.go 0.00% 1 Missing ⚠️
go/vt/vttablet/tabletmanager/rpc_vreplication.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-19.0   #15584      +/-   ##
================================================
+ Coverage         67.40%   67.43%   +0.03%     
================================================
  Files              1560     1560              
  Lines            192661   192655       -6     
================================================
+ Hits             129857   129923      +66     
+ Misses            62804    62732      -72     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mattlord mattlord merged commit 52ef808 into release-19.0 Mar 27, 2024
206 of 207 checks passed
@mattlord mattlord deleted the backport-15579-to-release-19.0 branch March 27, 2024 19:12
@mattlord mattlord changed the title [release-19.0] VReplication: Move the Reshard v2 workflow to vtctldclient (#15579) [release-19.0] Fix vtctldclient SwitchReads related bugs and move the ReshardV2 e2e test to vtctldclient (#15579) Mar 29, 2024
@mattlord mattlord changed the title [release-19.0] Fix vtctldclient SwitchReads related bugs and move the ReshardV2 e2e test to vtctldclient (#15579) [release-19.0] Fix vtctldclient SwitchReads related bugs and move the TestBasicV2Workflows e2e test to vtctldclient (#15579) Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants