-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-19.0] Fix vtctldclient SwitchReads related bugs and move the TestBasicV2Workflows e2e test to vtctldclient (#15579) #15584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matt Lord <[email protected]>
vitess-bot
bot
requested review from
mattlord,
harshit-gangal,
shlomi-noach and
ajm188
as code owners
March 27, 2024 17:18
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
mattlord
approved these changes
Mar 27, 2024
systay
approved these changes
Mar 27, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-19.0 #15584 +/- ##
================================================
+ Coverage 67.40% 67.43% +0.03%
================================================
Files 1560 1560
Lines 192661 192655 -6
================================================
+ Hits 129857 129923 +66
+ Misses 62804 62732 -72 ☔ View full report in Codecov by Sentry. |
mattlord
changed the title
[release-19.0] VReplication: Move the Reshard v2 workflow to vtctldclient (#15579)
[release-19.0] Fix vtctldclient SwitchReads related bugs and move the ReshardV2 e2e test to vtctldclient (#15579)
Mar 29, 2024
mattlord
changed the title
[release-19.0] Fix vtctldclient SwitchReads related bugs and move the ReshardV2 e2e test to vtctldclient (#15579)
[release-19.0] Fix vtctldclient SwitchReads related bugs and move the TestBasicV2Workflows e2e test to vtctldclient (#15579)
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Backport
This is a backport
Component: Build/CI
Component: VReplication
Type: Bug
Type: Internal Cleanup
Type: Testing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a backport of #15579
Fixes: #15594