Skip to content

Commit

Permalink
use snakecase for constant
Browse files Browse the repository at this point in the history
Signed-off-by: Harshit Gangal <[email protected]>
  • Loading branch information
harshit-gangal committed Jan 24, 2024
1 parent 0306a14 commit 3ea0b81
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions go/vt/vtgate/engine/delete_with_input.go
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ import (

var _ Primitive = (*DeleteWithInput)(nil)

const DM_VALS = "dm_vals"
const DmVals = "dm_vals"

// DeleteWithInput represents the instructions to perform a delete operation based on the input result.
type DeleteWithInput struct {
Expand Down Expand Up @@ -70,7 +70,7 @@ func (del *DeleteWithInput) TryExecute(ctx context.Context, vcursor VCursor, bin
bv = getBVMulti(inputRes, del.OutputCols)
}

bindVars[DM_VALS] = bv
bindVars[DmVals] = bv
return vcursor.ExecutePrimitive(ctx, del.Delete, bindVars, false)
}

Expand Down
2 changes: 1 addition & 1 deletion go/vt/vtgate/planbuilder/operators/query_planning.go
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ func createDeleteWithInput(ctx *plancontext.PlanningContext, in *Delete, src Ope
if len(leftComp) == 1 {
lhs = leftComp[0]
}
compExpr := sqlparser.NewComparisonExpr(sqlparser.InOp, lhs, sqlparser.ListArg(engine.DM_VALS), nil)
compExpr := sqlparser.NewComparisonExpr(sqlparser.InOp, lhs, sqlparser.ListArg(engine.DmVals), nil)

Check warning on line 167 in go/vt/vtgate/planbuilder/operators/query_planning.go

View check run for this annotation

Codecov / codecov/patch

go/vt/vtgate/planbuilder/operators/query_planning.go#L163-L167

Added lines #L163 - L167 were not covered by tests
targetQT := targetTable.QTable
qt := &QueryTable{
ID: targetQT.ID,
Expand Down

0 comments on commit 3ea0b81

Please sign in to comment.