Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExecuteFetch: error on multiple result sets #14949

Merged
merged 48 commits into from
Feb 14, 2024

code comments

db5de4f
Select commit
Loading
Failed to load commit list.
Merged

ExecuteFetch: error on multiple result sets #14949

code comments
db5de4f
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 14, 2024 in 0s

47.79% (+0.49%) compared to eddb39e

View this Pull Request on Codecov

47.79% (+0.49%) compared to eddb39e

Details

Codecov Report

Attention: 324 lines in your changes are missing coverage. Please review.

Comparison is base (eddb39e) 47.29% compared to head (db5de4f) 47.79%.
Report is 144 commits behind head on main.

❗ Current head db5de4f differs from pull request most recent head 9620d3c. Consider uploading reports for the commit 9620d3c to get more accurate results

Files Patch % Lines
...vt/vtgate/planbuilder/operators/sharded_routing.go 0.00% 40 Missing ⚠️
go/vt/vtgate/semantics/early_rewriter.go 84.81% 25 Missing and 11 partials ⚠️
...tgate/planbuilder/operators/aggregation_pushing.go 0.00% 25 Missing ⚠️
...vt/vtgate/planbuilder/operators/queryprojection.go 0.00% 20 Missing ⚠️
go/vt/vttablet/tabletmanager/rpc_query.go 58.69% 14 Missing and 5 partials ⚠️
go/vt/vtgate/evalengine/expr_tuple_bvar.go 62.50% 14 Missing and 4 partials ⚠️
go/mysql/query.go 21.05% 12 Missing and 3 partials ⚠️
go/vt/vttablet/grpctmclient/client.go 0.00% 15 Missing ⚠️
go/vt/vtgate/evalengine/cached_size.go 0.00% 10 Missing ⚠️
...gate/planbuilder/operators/info_schema_planning.go 0.00% 10 Missing ⚠️
... and 51 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #14949      +/-   ##
==========================================
+ Coverage   47.29%   47.79%   +0.49%     
==========================================
  Files        1137     1155      +18     
  Lines      238684   240335    +1651     
==========================================
+ Hits       112895   114868    +1973     
+ Misses     117168   116889     -279     
+ Partials     8621     8578      -43

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov