Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExecuteFetch: error on multiple result sets #14949

Merged
merged 48 commits into from
Feb 14, 2024

code comments

db5de4f
Select commit
Loading
Failed to load commit list.
Merged

ExecuteFetch: error on multiple result sets #14949

code comments
db5de4f
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Feb 14, 2024 in 0s

61.92% of diff hit (target 47.29%)

View this Pull Request on Codecov

61.92% of diff hit (target 47.29%)

Annotations

Check warning on line 240 in go/cmd/vtctldclient/command/root.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/cmd/vtctldclient/command/root.go#L240 

Added line #L240 was not covered by tests

Check warning on line 99 in go/mysql/capabilities/capability.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/mysql/capabilities/capability.go#L98-L99 

Added lines #L98 - L99 were not covered by tests

Check warning on line 107 in go/mysql/capabilities/capability.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/mysql/capabilities/capability.go#L106-L107 

Added lines #L106 - L107 were not covered by tests

Check warning on line 113 in go/mysql/capabilities/capability.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/mysql/capabilities/capability.go#L112-L113 

Added lines #L112 - L113 were not covered by tests

Check warning on line 212 in go/mysql/flavor.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/mysql/flavor.go#L212 

Added line #L212 was not covered by tests

Check warning on line 322 in go/mysql/query.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/mysql/query.go#L320-L322 

Added lines #L320 - L322 were not covered by tests

Check warning on line 333 in go/mysql/query.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/mysql/query.go#L331-L333 

Added lines #L331 - L333 were not covered by tests

Check warning on line 343 in go/mysql/query.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/mysql/query.go#L340-L343 

Added lines #L340 - L343 were not covered by tests

Check warning on line 502 in go/mysql/query.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/mysql/query.go#L501-L502 

Added lines #L501 - L502 were not covered by tests

Check warning on line 407 in go/vt/mysqlctl/mysqld.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/mysqlctl/mysqld.go#L407 

Added line #L407 was not covered by tests

Check warning on line 121 in go/vt/schemadiff/schema.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/schemadiff/schema.go#L121 

Added line #L121 was not covered by tests

Check warning on line 968 in go/vt/schemadiff/schema.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/schemadiff/schema.go#L967-L968 

Added lines #L967 - L968 were not covered by tests

Check warning on line 357 in go/vt/schemadiff/schema_diff.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/schemadiff/schema_diff.go#L356-L357 

Added lines #L356 - L357 were not covered by tests

Check warning on line 67 in go/vt/schemadiff/semantics.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/schemadiff/semantics.go#L66-L67 

Added lines #L66 - L67 were not covered by tests

Check warning on line 131 in go/vt/schemadiff/table.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/schemadiff/table.go#L130-L131 

Added lines #L130 - L131 were not covered by tests

Check warning on line 352 in go/vt/schemadiff/table.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/schemadiff/table.go#L351-L352 

Added lines #L351 - L352 were not covered by tests

Check warning on line 405 in go/vt/sidecardb/sidecardb.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/sidecardb/sidecardb.go#L405 

Added line #L405 was not covered by tests

Check warning on line 171 in go/vt/sqlparser/utils.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/sqlparser/utils.go#L170-L171 

Added lines #L170 - L171 were not covered by tests

Check warning on line 2165 in go/vt/vtadmin/api.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/vtadmin/api.go#L2165 

Added line #L2165 was not covered by tests

Check warning on line 113 in go/vt/vtctl/grpcvtctldserver/server.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/vtctl/grpcvtctldserver/server.go#L113 

Added line #L113 was not covered by tests

Check warning on line 4995 in go/vt/vtctl/grpcvtctldserver/server.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/vtctl/grpcvtctldserver/server.go#L4995 

Added line #L4995 was not covered by tests

Check warning on line 460 in go/vt/vtctl/workflow/materializer.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/vtctl/workflow/materializer.go#L460 

Added line #L460 was not covered by tests

Check warning on line 161 in go/vt/vtctl/workflow/server.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/vtctl/workflow/server.go#L161 

Added line #L161 was not covered by tests

Check warning on line 384 in go/vt/vtctl/workflow/switcher_dry_run.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/vtctl/workflow/switcher_dry_run.go#L384 

Added line #L384 was not covered by tests

Check warning on line 1350 in go/vt/vtctl/workflow/traffic_switcher.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/vtctl/workflow/traffic_switcher.go#L1350 

Added line #L1350 was not covered by tests
View more details on Codecov