-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleanup deprecated flag types in tabletenv #14733
cleanup deprecated flag types in tabletenv #14733
Conversation
Signed-off-by: Andrew Mason <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Signed-off-by: Andrew Mason <[email protected]>
Signed-off-by: Andrew Mason <[email protected]>
Signed-off-by: Andrew Mason <[email protected]>
Signed-off-by: Andrew Mason <[email protected]>
Signed-off-by: Andrew Mason <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Flag docs will be regenerated, right?
I added the website docs label more to kick CI than anything else, the check was pending. But it also felt appropriate.
seems like the bot hasn't been auto-generating the docs, so i'll look into why today. i'll do it manually for now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thanks for the hard work.
Description
This cleans up the deprecated float/duration interop flags in tabletenv to make them easier to viperize later.
Related Issue(s)
Checklist
Deployment Notes