-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: OnlineDDL cut-over backoff and force-cut-over #1641
Conversation
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
✅ Deploy Preview for vitess ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Shlomi Noach <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you generate the vtctldclient
docs for the new command as well?
Completely forgot how to do that 😬 |
in your particular case (I think):
edit: also you'll need to point it at your local vitess checkout https://github.com/vitessio/website/blob/prod/Makefile#L104 |
Signed-off-by: Shlomi Noach <[email protected]>
OK did that. That updated plenty CLI flags, but nothing related to the new command. I feel like we've been in this situation before. I did run
|
you need to make |
Signed-off-by: Shlomi Noach <[email protected]>
Absolutely right! My mistake. Alas: did that, now over 450 new files changes -- none of which depicts the new command. |
Signed-off-by: Shlomi Noach <[email protected]>
@ajm188 having merged vitessio/vitess#14546, I tried again using |
The newly added file is I still have some extra ~465 files changed, but I guess that's fine as it's just the commit SHA? Looking for your final approval before merging. |
Not sure why versions |
two things:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that said, this is fine to merge!
@ajm188 Thank you for the inspection and clarification! |
Documenting the changes in vitessio/vitess#14546:
ALTER VITESS_MIGRATION ... FORCE_CUTOVER ...
--force-cut-over-after
strategy flag