Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make connection killing resilient to MySQL hangs #14500

Merged
merged 9 commits into from
Mar 4, 2024

Fix test case to properly wait for all queries to be pending.

c1ca7b6
Select commit
Loading
Failed to load commit list.
Merged

Make connection killing resilient to MySQL hangs #14500

Fix test case to properly wait for all queries to be pending.
c1ca7b6
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 4, 2024 in 0s

65.45% (-1.97%) compared to 696fe0e

View this Pull Request on Codecov

65.45% (-1.97%) compared to 696fe0e

Details

Codecov Report

Attention: Patch coverage is 91.35802% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 65.45%. Comparing base (696fe0e) to head (c1ca7b6).
Report is 69 commits behind head on main.

Files Patch % Lines
go/vt/vttablet/tabletserver/connpool/dbconn.go 93.33% 5 Missing ⚠️
go/mysql/fakesqldb/server.go 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14500      +/-   ##
==========================================
- Coverage   67.41%   65.45%   -1.97%     
==========================================
  Files        1560     1562       +2     
  Lines      192752   193922    +1170     
==========================================
- Hits       129952   126927    -3025     
- Misses      62800    66995    +4195     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.