Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make connection killing resilient to MySQL hangs #14500

Merged
merged 9 commits into from
Mar 4, 2024
+226 −89

Fix test case to properly wait for all queries to be pending.

c1ca7b6
Select commit
Loading
Failed to load commit list.
Merged

Make connection killing resilient to MySQL hangs #14500

Fix test case to properly wait for all queries to be pending.
c1ca7b6
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Mar 4, 2024 in 0s

91.35% of diff hit (target 67.41%)

View this Pull Request on Codecov

91.35% of diff hit (target 67.41%)

Annotations

Check warning on line 383 in go/mysql/fakesqldb/server.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/mysql/fakesqldb/server.go#L383 

Added line #L383 was not covered by tests

Check warning on line 397 in go/mysql/fakesqldb/server.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/mysql/fakesqldb/server.go#L397 

Added line #L397 was not covered by tests

Check warning on line 285 in go/vt/vttablet/tabletserver/connpool/dbconn.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/vttablet/tabletserver/connpool/dbconn.go#L283-L285 

Added lines #L283 - L285 were not covered by tests

Check warning on line 288 in go/vt/vttablet/tabletserver/connpool/dbconn.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

go/vt/vttablet/tabletserver/connpool/dbconn.go#L287-L288 

Added lines #L287 - L288 were not covered by tests
View more details on Codecov