Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement tiles showcase expand script #49

Merged
merged 3 commits into from
Nov 13, 2024
Merged

feat: implement tiles showcase expand script #49

merged 3 commits into from
Nov 13, 2024

Conversation

paulovareiro29
Copy link
Collaborator

Closes #38

@paulovareiro29 paulovareiro29 mentioned this pull request Nov 6, 2024
Closed
koepferd
koepferd requested changes Nov 8, 2024
View reviewed changes
Copy link
Collaborator

@koepferd koepferd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please implement aria-live="polite" on the changing button and div that contains the tiles

@paulovareiro29 paulovareiro29 merged commit 97ef88a into main Nov 13, 2024
2 checks passed
@paulovareiro29 paulovareiro29 deleted the feat/implement-tiles-showcase-expand-script branch November 13, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koepferd koepferd koepferd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Home - Extended Categories
2 participants
@paulovareiro29 @koepferd