Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Home - Extended Categories #38

Closed
stefan-korn opened this issue Oct 23, 2024 · 2 comments · Fixed by #49
Closed

Home - Extended Categories #38

stefan-korn opened this issue Oct 23, 2024 · 2 comments · Fixed by #49
Assignees
Labels
enhancement New feature or request

Comments

@stefan-korn
Copy link
Contributor

stefan-korn commented Oct 23, 2024

If we really want to go with the feature of "extending" categories on the homepage, we would need some kind of toggle solution.

This toggle solution should be provided within this repo then.

I am bit reluctant on the current approach to hide categories based on viewport. This would probably make a toggle solution more difficult. In the current approach of extended categories (which maybe is only a "mockup") it just cuts off some categories in smaller viewports, which surely is no viable solution.

From my perspective we would not absolutely need the "extending" feature, so just displaying all categories in multiple rows would be acceptable for me too. This is maybe something we can discuss during next weekly @koepferd ?
Since this is actually tied to a controlled EU vocabulary, the maximum number of categories is currently 13. The vocabulary maybe extended in the future, but hasn't since 2015, so probably it might stay the same.

And it would be better from Drupal perspective to use bootstrap row columns on this.

@koepferd : Something off-topic: Could you maybe add https://github.com/DKANCologneServiceOwner to this repo, so we can mention on some issues?

@paulovareiro29 paulovareiro29 self-assigned this Oct 29, 2024
@paulovareiro29 paulovareiro29 added the enhancement New feature or request label Oct 29, 2024
@koepferd
Copy link
Collaborator

Hi @stefan-korn,
we discussed this yesterday.
From UX perspective we will keep this functionality. @paulovareiro29 will implement the toggle solution.

Also I invited this DKAN user to the repository, they should check their invites.

@paulovareiro29
Copy link
Collaborator

Hi @stefan-korn ,
PR #49 was created to implement the expanding script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants