Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Application Commands fix. #629

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Conversation

false-fox
Copy link

@false-fox false-fox commented May 21, 2024

Fixes #476, #526, #535 (partially) and #487. Undiscord attempts to delete application/bot messages initialized by the user, but receives a 403 error and hangs.

I added a filter to the messageToDelete array to exclude bots, and a coresponding menu option to toggle the feature.

Features

Provides a UI option under the filter category

imssage

Provides a console log that bot messages will be skipped

asdasdasdasdasdasd

Works on an elegantly simple filter.

~line 318 of undiscord-core.js

if (this.options.IncludeApplications == false) {
    messagesToDelete = messagesToDelete.filter(msg => !msg.author.bot)
}

Notes

I figured including application messages should be "opt in" as in most use cases users won't have manage messages perms. Let me know if this should be changed and it's a simple fix.

@ivystopia
Copy link

This branch fixed #487 for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slash Commands are being reported as belonging to user but can't be deleted.
2 participants