Bug: Tries to delete MEE6 Messages + Thread Messages (+ slows PC)

[JayBoom]

Undiscord Version

v5.2.3

Browser

115.0.5790.110 (Official Build) (64-bit)

Extension

Tampermonkey

Reproduction steps

1. Tried to delete messages before a certain date

Actual results

Tries to delete MEE6 bot messages:
Error deleting message, API responded with status 403! {"message":"Missing Permissions","code":50013}

As well as thread messages:
Error deleting message (Thread is archived). Will increment offset so we don't search this in the next page...

(Does the thread one above 100's of times)

Expected results

Skip MEE6 messages and archived thread messages

Bug affects

• DMs
• DMs (group)
• Channels
• Channel (NSFW)

Additional information & file uploads

[JayBoom]

I believe @ckcr4lyf may have a found a solution is #520 for the Archived threads, as well as #526 maybe having a line from @CactusHamster on the MEE6/bot/slash command error messages

[ckcr4lyf]

For Error deleting message (Thread is archived). Will increment offset so we don't search this in the next page... , this is just a WARN message, and it will skip it.

Previously this would hard error and reach an unusable state, but I fixed it in #518

[ckcr4lyf]

That is to say, the expected behavior is already "correct" for archived messages, i.e. "skipped". (A warning is printed so that the user knows some stuff was not deleted).

[JayBoom]

That is to say, the expected behavior is already "correct" for archived messages, i.e. "skipped". (A warning is printed so that the user knows some stuff was not deleted).

But it got stuck for 16 hours on that, it was 4 years of data but it was just stuck on archived messages, using the fix in #520 fixed this and I got it done though fortunately, as well as putting in the line of code from #526 fixed the MEE6 bot issues, I would recommend putting these in main :)

[ckcr4lyf]

I would recommend putting these in main :)

Let's see when the author has time to review it. Till then I guess you'll need to use your fork

[karcfa]

same here. it tries to remove DISBOARD (/bump) and MEEE(?) messages and it slows down the operation a lot. It also wont remove many legit messages by the way, but it did in the past.

[ckcr4lyf]

@karcfa can you try the patch in #526 and see if that fixes it? You could comment your feedback in there.

[karcfa]

@karcfa can you try the patch in #526 and see if that fixes it? You could comment your feedback in there.

Hi, it started deleting again, thanks
i added this line at this position:

I also recommend to set the delay before switching to next page to 5 seconds or something because the default 30 second would be too long and would also apply when the bot didnt remove anything on current page (cause they were all skipped)
(Not sure)

[false-fox]

Fixed partially in #629 :)