Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add trimgalore #117

Merged
merged 13 commits into from
Sep 23, 2024
Merged

Add trimgalore #117

merged 13 commits into from
Sep 23, 2024

Conversation

sainirmayi
Copy link
Contributor

@sainirmayi sainirmayi commented Aug 5, 2024 •
edited
Loading

Description

Issue ticket number

Closes #xxxx

Checklist before requesting a review

  • I have performed a self-review of my code

  • Conforms to the Contributing guidelines

  • Proposed changes are described in the CHANGELOG.md

  • I have tested my code with viash ns test --parallel -q <name or namespace>

  • Check the correct box. Does this PR contain:

    • Breaking changes
    • New functionality
    • Major changes
    • Minor changes
    • Documentation
    • Bug fixes

@sainirmayi sainirmayi marked this pull request as ready for review August 19, 2024 08:11
@sainirmayi sainirmayi requested a review from rcannood August 19, 2024 08:23
@tverbeiren tverbeiren self-requested a review September 9, 2024 13:30
tverbeiren
tverbeiren requested changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@tverbeiren tverbeiren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see the remarks below.

src/trimgalore/config.vsh.yaml Outdated Show resolved Hide resolved
src/trimgalore/config.vsh.yaml Outdated Show resolved Hide resolved
src/trimgalore/config.vsh.yaml Outdated Show resolved Hide resolved
src/trimgalore/config.vsh.yaml Outdated Show resolved Hide resolved
src/trimgalore/config.vsh.yaml Show resolved Hide resolved
src/trimgalore/config.vsh.yaml Outdated Show resolved Hide resolved
src/trimgalore/config.vsh.yaml Outdated Show resolved Hide resolved
src/trimgalore/config.vsh.yaml Outdated Show resolved Hide resolved
src/trimgalore/script.sh Show resolved Hide resolved
src/trimgalore/script.sh Outdated Show resolved Hide resolved
tverbeiren
tverbeiren approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@tverbeiren tverbeiren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The set -e is superfluous in the test.sh script.

Apart from that, lgtm!

@sainirmayi sainirmayi merged commit 63de1c1 into main Sep 23, 2024
3 checks passed
@sainirmayi sainirmayi deleted the add_trimgalore branch September 23, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tverbeiren tverbeiren tverbeiren approved these changes

@rcannood rcannood Awaiting requested review from rcannood

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sainirmayi @tverbeiren @rcannood