Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add agat convert minimap2 bam2gff #113

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

Leila011
Copy link
Contributor

@Leila011 Leila011 commented Aug 4, 2024

Description

add agat_convert_minimap2_bam2gff

Issue ticket number

Closes #xxxx

Checklist before requesting a review

  • I have performed a self-review of my code

  • Conforms to the Contributing guidelines

  • Proposed changes are described in the CHANGELOG.md

  • I have tested my code with viash ns test --parallel -q <name or namespace>

  • Check the correct box. Does this PR contain:

    • Breaking changes
    • New functionality
    • Major changes
    • Minor changes
    • Documentation
    • Bug fixes

@Leila011 Leila011 marked this pull request as ready for review August 4, 2024 12:10
@Leila011 Leila011 requested review from rcannood and DriesSchaumont and removed request for rcannood August 4, 2024 12:11
@sainirmayi sainirmayi self-requested a review September 27, 2024 09:01
src/agat/agat_convert_minimap2_bam2gff/config.vsh.yaml Outdated Show resolved Hide resolved
src/agat/agat_convert_minimap2_bam2gff/config.vsh.yaml Outdated Show resolved Hide resolved
path: test_data
engines:
- type: docker
image: quay.io/biocontainers/agat:1.4.0--pl5321hdfd78af_0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be better to update the docker setup so that samtools is also installed?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can the test data be subsampled?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants