Restore the TUScope only when we are not in incremental processing mode. #876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The TUScope is set to nullptr in Sema::ActOnEndOfTranslationUnit onlu when incremental processing mode in off. This makes the state of Sema more consistent when Clad is on/off.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #876 +/- ##
=======================================
Coverage 94.81% 94.82%
=======================================
Files 52 52
Lines 7701 7703 +2
=======================================
+ Hits 7302 7304 +2
Misses 399 399
|
|
clang-tidy review says "All clean, LGTM! 👍" |
parth-07
approved these changes
May 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TUScope is set to nullptr in Sema::ActOnEndOfTranslationUnit onlu when incremental processing mode in off. This makes the state of Sema more consistent when Clad is on/off.