Provide a backup plan if we fail to delay the handling of declarations. #877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #877 +/- ##
==========================================
- Coverage 94.82% 94.77% -0.05%
==========================================
Files 52 52
Lines 7703 7714 +11
==========================================
+ Hits 7304 7311 +7
- Misses 399 403 +4
|
|
clang-tidy review says "All clean, LGTM! 👍" |
vgvassilev
force-pushed
the
non-standard-repls
branch
from
13f0e86 to
c529893
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
|
I am not sure if we can test this patch - it will need to have either cling or some sort of cling-like infrastructure which is probably not worth maintaining in a long run. |
vaithak
reviewed
May 6, 2024
| // We could not delay the process due to some strange way of | ||
| // initialization, inform the consumers now. | ||
| if (!m_Multiplexer) | ||
| m_CI.getASTConsumer().HandleTopLevelDecl(DCI.m_DGR); |
There was a problem hiding this comment.
If we are not delaying the call, do we still want to add it to AppendDelayed?
There was a problem hiding this comment.
I’d think so. That’d give us some uniform debugging capabilities for both cases….
vaithak
approved these changes
May 6, 2024
This patch enhances the work done in #766 where we assumed the clients are going to be well-behaved such as clang or clang-repl. However, we can have clients which connect the clang components in a non-standard way and we should provide a reasonable fallback. This patch detects if the setup is non-standard and teaches clad to handle requests as they come, pretty much the same way as before #766 was implemented. Of course this comes with a cost when we try to differentiate declarations that are defined later in the translation unit. We expect such setups to be rare and mostly in the cases of incremental processing and old repls such as Cling.
vgvassilev
force-pushed
the
non-standard-repls
branch
from
c529893 to
ebe60e0
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch enhances the work done in #766 where we assumed the clients are going to be well-behaved such as clang or clang-repl. However, we can have clients which connect the clang components in a non-standard way and we should provide a reasonable fallback.
This patch detects if the setup is non-standard and teaches clad to handle requests as they come, pretty much the same way as before #766 was implemented. Of course this comes with a cost when we try to differentiate declarations that are defined later in the translation unit. We expect such setups to be rare and mostly in the cases of incremental processing and old repls such as Cling.
Depends on #876.