Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #80, by using utf8 for all characters #82

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix #80, by using utf8 for all characters #82

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions db_to_utf8.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
ALTER TABLE `flink_ecosystem`.`package`
CHANGE COLUMN `slug` `slug` VARCHAR(255) CHARACTER SET 'utf8' NOT NULL DEFAULT '' ,
CHANGE COLUMN `name` `name` VARCHAR(255) CHARACTER SET 'utf8' NOT NULL DEFAULT '' ,
CHANGE COLUMN `description` `description` LONGTEXT CHARACTER SET 'utf8' NOT NULL ,
CHANGE COLUMN `readme` `readme` LONGTEXT CHARACTER SET 'utf8' NOT NULL ,
CHANGE COLUMN `website` `website` VARCHAR(255) CHARACTER SET 'utf8' NOT NULL DEFAULT '' ,
CHANGE COLUMN `repository` `repository` VARCHAR(255) CHARACTER SET 'utf8' NOT NULL DEFAULT '' ,
CHANGE COLUMN `license` `license` VARCHAR(255) CHARACTER SET 'utf8' NOT NULL DEFAULT '' ,
CHANGE COLUMN `category` `category` VARCHAR(255) CHARACTER SET 'utf8' NOT NULL DEFAULT '' ,
CHANGE COLUMN `tags` `tags` VARCHAR(255) CHARACTER SET 'utf8' NULL DEFAULT '' ;

ALTER TABLE `flink_ecosystem`.`comment`
CHANGE COLUMN `text` `text` LONGTEXT CHARACTER SET 'utf8' NOT NULL ;
1 change: 1 addition & 0 deletions src/server/routes/api/v1/packages/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,7 @@ exports.post = [
message: `the package id "${ctx.request.body.slug}" is already in use`,
});
default:
console.log("Caught exception", e);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can help with this, but it probably just makes sense to have logs happen for every time there is a ctx.throw (we don't need to to this now, but maybe write an issue for the future)

return ctx.throw(500, { message: "an unknown error has occured" });
}
}
Expand Down
20 changes: 10 additions & 10 deletions src/server/sql/schema.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ CREATE TABLE `comment` (
`id` int(11) unsigned NOT NULL AUTO_INCREMENT,
`package_id` int(11) NOT NULL,
`user_id` int(11) NOT NULL,
`text` longtext NOT NULL,
`text` longtext CHARACTER SET 'utf8' NOT NULL,
`added` datetime NOT NULL DEFAULT '0000-00-00 00:00:00',
`updated` datetime NOT NULL DEFAULT '0000-00-00 00:00:00' ON UPDATE current_timestamp(),
`deleted` tinyint(1) NOT NULL DEFAULT 0,
Expand All @@ -16,17 +16,17 @@ CREATE TABLE `comment` (
-- Create syntax for TABLE 'package'
CREATE TABLE `package` (
`id` int(11) unsigned NOT NULL AUTO_INCREMENT,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note to future self / other maintainers: these changes are untested.

`slug` varchar(255) NOT NULL DEFAULT '',
`name` varchar(255) NOT NULL DEFAULT '',
`slug` varchar(255) CHARACTER SET 'utf8' NOT NULL DEFAULT '',
`name` varchar(255) CHARACTER SET 'utf8' NOT NULL DEFAULT '',
`user_id` int(11) NOT NULL,
`description` longtext NOT NULL,
`readme` longtext NOT NULL,
`description` longtext CHARACTER SET 'utf8' NOT NULL,
`readme` longtext CHARACTER SET 'utf8' NOT NULL,
`image_id` int(11) NOT NULL DEFAULT 0,
`website` varchar(255) NOT NULL DEFAULT '',
`repository` varchar(255) NOT NULL DEFAULT '',
`license` varchar(255) NOT NULL DEFAULT '',
`category` varchar(255) NOT NULL DEFAULT '',
`tags` varchar(255) DEFAULT '',
`website` varchar(255) CHARACTER SET 'utf8' NOT NULL DEFAULT '',
`repository` varchar(255) CHARACTER SET 'utf8' NOT NULL DEFAULT '',
`license` varchar(255) CHARACTER SET 'utf8' NOT NULL DEFAULT '',
`category` varchar(255) CHARACTER SET 'utf8' NOT NULL DEFAULT '',
`tags` varchar(255) CHARACTER SET 'utf8' DEFAULT '',
`added` datetime NOT NULL DEFAULT '0000-00-00 00:00:00',
`updated` datetime NOT NULL DEFAULT '0000-00-00 00:00:00' ON UPDATE current_timestamp(),
`deleted` tinyint(1) NOT NULL DEFAULT 0,
Expand Down