Fix #80, by using utf8 for all characters #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmetzger
commented
Nov 14, 2019
| @@ -16,17 +16,17 @@ CREATE TABLE `comment` ( | |||
| -- Create syntax for TABLE 'package' | |||
| CREATE TABLE `package` ( | |||
| `id` int(11) unsigned NOT NULL AUTO_INCREMENT, | |||
There was a problem hiding this comment.
note to future self / other maintainers: these changes are untested.
|
Applied the fix to the "production" server :) |
sorahn
suggested changes
Nov 14, 2019
There was a problem hiding this comment.
After chatting with @rmetzger we believe this issue was actually caused by the mariadb docker setup.
Proposed fix is to add the following code to the database section of the docker compose file so that the database is actually created as it should be.
commmand:
- --character-set-server=utf8mb4
- --collation-server=utf8mb4_unicode_ci
| @@ -104,6 +104,7 @@ exports.post = [ | |||
| message: `the package id "${ctx.request.body.slug}" is already in use`, | |||
| }); | |||
| default: | |||
| console.log("Caught exception", e); | |||
There was a problem hiding this comment.
I can help with this, but it probably just makes sense to have logs happen for every time there is a ctx.throw (we don't need to to this now, but maybe write an issue for the future)
rmetzger
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.