Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update dependencies #29

Merged

Conversation

pmpak
Copy link

@pmpak pmpak commented Nov 22, 2023

Updated packages to their latest version except gettext-parser since there are a lot of changes that might affect the usage of the library.

Removed packages that were not used in the library:

  • boxen

  • path

  • terminal-link

  • cross-env

  • @types/flat (redundant after v6)

  • Updated eslint quote rule to avoid escaping quotes

Updated packages to their latest version except `gettext-parser`
since there are a lot of changes that might affect the usage of
the library.

Removed packages that were not used in the library:
- boxen
- path
- terminal-link
- cross-env
- @types/flat (redundant after v6)

- Updated eslint quote rule to avoid escaping quotes
@pmpak
Copy link
Author

pmpak commented Nov 22, 2023

I also noticed that prettier is there but not actively used (no prettier configuration anywhere). However, a change related to prettier can be another PR dedicated to syntax fixings

@pmpak
Copy link
Author

pmpak commented Nov 23, 2023

I noticed now that the prettier configuration is in the package.json so it's all fine

@michaelbromley michaelbromley merged commit c28c8ba into vendure-ecommerce:master Nov 23, 2023
2 checks passed
@michaelbromley
Copy link
Member

Thanks! I love PRs that remove more lines than they add 👍

@pmpak pmpak deleted the chore/update-dependencies branch November 23, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants