Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: split package into core and pro #242

Merged
merged 2 commits into from
May 6, 2024

Conversation

web-padawan
Copy link
Member

Description

Reverts #236

Re-applies #230

Type of change

  • Refactor

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.86%. Comparing base (6c67a6c) to head (0c88767).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #242      +/-   ##
==========================================
- Coverage   95.89%   94.86%   -1.03%     
==========================================
  Files          30       30              
  Lines         292      292              
  Branches       35       35              
==========================================
- Hits          280      277       -3     
  Misses          3        3              
- Partials        9       12       +3     
Flag Coverage Δ
unittests 94.86% <ø> (-1.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@yuriy-fix yuriy-fix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not merge the PR before beta period

@web-padawan web-padawan force-pushed the refactor/split-package-again branch 5 times, most recently from 6910ff1 to b161257 Compare May 2, 2024 11:04
@web-padawan web-padawan force-pushed the refactor/split-package-again branch from b161257 to 3fcd2a6 Compare May 2, 2024 11:25
@mshabarov
Copy link

@yuriy-fix we've just released the 24.4 beta, let's start merging and releasing the restructured React components?

@web-padawan web-padawan removed the request for review from sissbruecker May 3, 2024 08:01
@web-padawan web-padawan merged commit 12c3b81 into main May 6, 2024
2 checks passed
@web-padawan web-padawan deleted the refactor/split-package-again branch May 6, 2024 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants