Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split react-components into core and pro parts #5204

Closed
3 tasks done
Tracked by #5012
mshabarov opened this issue Apr 2, 2024 · 4 comments
Closed
3 tasks done
Tracked by #5012

Split react-components into core and pro parts #5204

mshabarov opened this issue Apr 2, 2024 · 4 comments

Comments

@mshabarov
Copy link
Contributor

mshabarov commented Apr 2, 2024

Describe your motivation

Vaadin Core / open source users should be able to use core/free React components without Vaadin license.

Describe the solution you'd like

Acceptance Criteria:

  • React components are split into @vaadin/react-components (free) and @vaadin/react-components-pro (commercial) npm packages, this change is re-applied
  • Platform versions has react-components in core and react-components-pro in vaadin
  • Flow adds @vaadin/react-components-pro package into package.json in vaadin dependency is used in a project. @vaadin/react-components are added for both vaadin-core and vaadin.

Note: this is planned between 24.4 beta and GA, so that these changes don't block beta release and beta testing.

Describe alternatives you've considered

No response

Additional context

Vaadin 24.4.

@web-padawan
Copy link
Member

Created the React components split PR: vaadin/react-components#242

caalador added a commit to vaadin/flow that referenced this issue Apr 4, 2024
Extend the test so that we test using
react-components-pro from the
vaadin-versions.json file.

Remove unused parameter.

part of vaadin/platform#5204
@caalador
Copy link
Contributor

caalador commented Apr 4, 2024

Flow will pick/discard react components by the mode flag ("mode": "react") in the versions files and both vaadin-core-versions.json and vaadin-versions.json are always checked if available so for Flow there is nothing extra for step 3 to add.

Extended test to check this case explicitly: vaadin/flow#19103

@ZheSun88
Copy link
Contributor

ZheSun88 commented Apr 5, 2024

i have pushed a branch in platform with the necessary changes. let us wait after beta
https://github.com/vaadin/platform/tree/react-component-pro

tltv pushed a commit to vaadin/flow that referenced this issue Apr 8, 2024
Extend the test so that we test using
react-components-pro from the
vaadin-versions.json file.

Remove unused parameter.

part of vaadin/platform#5204
@mshabarov
Copy link
Contributor Author

Done. Tested with having vaadin and vaadin-core. Vaadin adds react-components-pro in the first case and does not in the second case.

@github-project-automation github-project-automation bot moved this from 🟢Ready to Go to Done in Vaadin Flow ongoing work (Vaadin 10+) May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

4 participants