-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split react-components into core and pro parts #5204
Comments
Created the React components split PR: vaadin/react-components#242 |
Extend the test so that we test using react-components-pro from the vaadin-versions.json file. Remove unused parameter. part of vaadin/platform#5204
Flow will pick/discard react components by the mode flag ("mode": "react") in the versions files and both Extended test to check this case explicitly: vaadin/flow#19103 |
i have pushed a branch in platform with the necessary changes. let us wait after beta |
Extend the test so that we test using react-components-pro from the vaadin-versions.json file. Remove unused parameter. part of vaadin/platform#5204
Done. Tested with having |
Describe your motivation
Vaadin Core / open source users should be able to use core/free React components without Vaadin license.
Describe the solution you'd like
Acceptance Criteria:
@vaadin/react-components
(free) and@vaadin/react-components-pro
(commercial) npm packages, this change is re-appliedreact-components
incore
andreact-components-pro
invaadin
@vaadin/react-components-pro
package intopackage.json
invaadin
dependency is used in a project.@vaadin/react-components
are added for bothvaadin-core
andvaadin
.Note: this is planned between 24.4 beta and GA, so that these changes don't block beta release and beta testing.
Describe alternatives you've considered
No response
Additional context
Vaadin 24.4.
The text was updated successfully, but these errors were encountered: