Fix release asset links for usnistgov/OSCAL-Pages#48 #30
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the issue above, we need to fix two issues to make sure that the release asset link generation functions correctly.
RELEASE_ASSET_REDIRECTS_DIR
to its default value after the relevant build target. This fails silently.list-release-artifacts
for usnistgov/OSCAL includes the relative path for the artifacts, not just the file names. So the following path is created.site/public/release-assets/latest/generated/oscal_complete_schema.xsd/index.html
The intended result is below.
site/public/release-assets/latest/oscal_complete_schema.xsd/index.html
A workaround in generate_release_assets_redirect.sh was used to blank out the sub-directory.