Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aliases to old control layer catalog layer subdirectory examples missing #48

Closed
3 tasks done
aj-stein-nist opened this issue Sep 21, 2023 · 6 comments · Fixed by usnistgov/OSCAL-Reference#30 or #60
Closed
3 tasks done
Assignees
Labels
bug Something isn't working

Comments

@aj-stein-nist
Copy link
Collaborator

aj-stein-nist commented Sep 21, 2023

Per an earlier report from community members via @iMichaela, some other aliaseses were not added by me in #38 for #24. The following are SP 800-53 example page of missing control layer link issues that must have aliases added.

  • Add alias /resources/concepts/layer/control/catalog/sp800-53rev5-example/ -> /concepts/layer/control/catalog/sp800-53rev5-example/
  • Review all /resources subdirectory pages and ensure all aliases are updated
  • Review with tech lead and team to determine best course of action for link checking external to the site and consider checking historic links pre-alias for better testing, if feasible
@aj-stein-nist aj-stein-nist added the bug Something isn't working label Sep 21, 2023
@aj-stein-nist aj-stein-nist moved this from Todo to Needs Triage in NIST OSCAL Work Board Sep 21, 2023
@aj-stein-nist
Copy link
Collaborator Author

Given the approval and changes in usnistgov/OSCAL-Reference#22, it seems we should triage this as some links are still missing.

/cc @Arminta-Jenkins-NIST

@Arminta-Jenkins-NIST
Copy link
Contributor

At 9/28 Triage Meeting: @nikitawootten-nist - Hugo generated site map file can help find these issues.

@Arminta-Jenkins-NIST Arminta-Jenkins-NIST moved this from Needs Triage to Todo in NIST OSCAL Work Board Sep 28, 2023
@iMichaela
Copy link
Contributor

iMichaela commented Oct 12, 2023

Pages with invalid links are listed below, and the broken links are included. Finding the best way of programmatically addressing them to point to the latest OSCAL release and not hardcoded to v1.1.1 would be important.

@iMichaela iMichaela moved this from Todo to In Progress in NIST OSCAL Work Board Oct 12, 2023
@iMichaela iMichaela self-assigned this Oct 12, 2023
@Arminta-Jenkins-NIST Arminta-Jenkins-NIST self-assigned this Oct 13, 2023
@aj-stein-nist
Copy link
Collaborator Author

Moving forward to next sprint.

aj-stein-nist added a commit to usnistgov/OSCAL-Reference that referenced this issue Oct 24, 2023
As part of the issue above, we need to fix two issues to make sure that
the release asset link generation functions correctly.

1. In the Makefile, we were binding `RELEASE_ASSET_REDIRECTS_DIR` to its
default value after the relevant build target. This fails silently.
1. While testing and troubleshooting fix 1, we noticed that the make
target `list-release-artifacts` for usnistgov/OSCAL includes the relative
path for the artifacts, not just the file names. So the following path
is created.

site/public/release-assets/latest/generated/oscal_complete_schema.xsd/index.html

The intended result is below.

site/public/release-assets/latest/oscal_complete_schema.xsd/index.html

A workaround in generate_release_assets_redirect.sh was used to blank
out the sub-directory.
aj-stein-nist added a commit that referenced this issue Oct 24, 2023
Co-Authored-By: Arminta Jenkins <[email protected]>
aj-stein-nist added a commit to usnistgov/OSCAL-Reference that referenced this issue Oct 25, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in NIST OSCAL Work Board Oct 25, 2023
@aj-stein-nist
Copy link
Collaborator Author

The issue auto-closing for the first PR was a mistake, per discussion with @Arminta-Jenkins-NIST, reopening.

@aj-stein-nist aj-stein-nist reopened this Oct 26, 2023
@github-project-automation github-project-automation bot moved this from Done to Needs Triage in NIST OSCAL Work Board Oct 26, 2023
@aj-stein-nist aj-stein-nist moved this from Needs Triage to In Progress in NIST OSCAL Work Board Oct 26, 2023
@aj-stein-nist aj-stein-nist moved this from In Progress to Under Review in NIST OSCAL Work Board Oct 26, 2023
aj-stein-nist added a commit that referenced this issue Nov 1, 2023
Co-Authored-By: Arminta Jenkins <[email protected]>
@aj-stein-nist
Copy link
Collaborator Author

I finished up preparation before the sprint planning, but this is more or less done. I fixed the several errors I had not corrected as brought up by @iMichaela in #60. It should be good for final review and merge.

/cc @Arminta-Jenkins-NIST

aj-stein-nist added a commit that referenced this issue Nov 2, 2023
…esources/ (#60)

* Update broken links for #48.

Co-Authored-By: Arminta Jenkins <[email protected]>

* updated 3 FedRAMP links and XML-JSON converter links.

* I corrected the link for TESTING NEW RELEASES.

* Add missing implementation layer index alias.

---------

Co-authored-by: Arminta Jenkins <[email protected]>
@github-project-automation github-project-automation bot moved this from Under Review to Done in NIST OSCAL Work Board Nov 2, 2023
nikitawootten-nist pushed a commit that referenced this issue Nov 20, 2023
…esources/ (#60)

* Update broken links for #48.

Co-Authored-By: Arminta Jenkins <[email protected]>

* updated 3 FedRAMP links and XML-JSON converter links.

* I corrected the link for TESTING NEW RELEASES.

* Add missing implementation layer index alias.

---------

Co-authored-by: Arminta Jenkins <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
3 participants