-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aliases to old control layer catalog layer subdirectory examples missing #48
Aliases to old control layer catalog layer subdirectory examples missing #48
Comments
Given the approval and changes in usnistgov/OSCAL-Reference#22, it seems we should triage this as some links are still missing. |
At 9/28 Triage Meeting: @nikitawootten-nist - Hugo generated site map file can help find these issues. |
Moving forward to next sprint. |
As part of the issue above, we need to fix two issues to make sure that the release asset link generation functions correctly. 1. In the Makefile, we were binding `RELEASE_ASSET_REDIRECTS_DIR` to its default value after the relevant build target. This fails silently. 1. While testing and troubleshooting fix 1, we noticed that the make target `list-release-artifacts` for usnistgov/OSCAL includes the relative path for the artifacts, not just the file names. So the following path is created. site/public/release-assets/latest/generated/oscal_complete_schema.xsd/index.html The intended result is below. site/public/release-assets/latest/oscal_complete_schema.xsd/index.html A workaround in generate_release_assets_redirect.sh was used to blank out the sub-directory.
Co-Authored-By: Arminta Jenkins <[email protected]>
Fix release asset links for usnistgov/OSCAL-Pages#48
The issue auto-closing for the first PR was a mistake, per discussion with @Arminta-Jenkins-NIST, reopening. |
Co-Authored-By: Arminta Jenkins <[email protected]>
I finished up preparation before the sprint planning, but this is more or less done. I fixed the several errors I had not corrected as brought up by @iMichaela in #60. It should be good for final review and merge. |
…esources/ (#60) * Update broken links for #48. Co-Authored-By: Arminta Jenkins <[email protected]> * updated 3 FedRAMP links and XML-JSON converter links. * I corrected the link for TESTING NEW RELEASES. * Add missing implementation layer index alias. --------- Co-authored-by: Arminta Jenkins <[email protected]>
…esources/ (#60) * Update broken links for #48. Co-Authored-By: Arminta Jenkins <[email protected]> * updated 3 FedRAMP links and XML-JSON converter links. * I corrected the link for TESTING NEW RELEASES. * Add missing implementation layer index alias. --------- Co-authored-by: Arminta Jenkins <[email protected]>
Per an earlier report from community members via @iMichaela, some other aliaseses were not added by me in #38 for #24. The following are SP 800-53 example page of missing control layer link issues that must have aliases added.
/resources/concepts/layer/control/catalog/sp800-53rev5-example/
->/concepts/layer/control/catalog/sp800-53rev5-example/
/resources
subdirectory pages and ensure all aliases are updatedThe text was updated successfully, but these errors were encountered: